Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2385)

Unified Diff: chrome/browser/ui/cocoa/passwords/signin_promo_view_controller_unittest.mm

Issue 2653733006: Remove the Finch experiment for the sign-in promo in the password bubble. (Closed)
Patch Set: fix mac/2 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/passwords/signin_promo_view_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/passwords/signin_promo_view_controller_unittest.mm b/chrome/browser/ui/cocoa/passwords/signin_promo_view_controller_unittest.mm
index 1ce68663d667a46a6be9def407357edc4968e673..1fd28fae6787d4cce7eaed3eaa7cc3e6ecb34093 100644
--- a/chrome/browser/ui/cocoa/passwords/signin_promo_view_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/passwords/signin_promo_view_controller_unittest.mm
@@ -4,21 +4,13 @@
#import "chrome/browser/ui/cocoa/passwords/signin_promo_view_controller.h"
-#include "base/metrics/field_trial.h"
#import "chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.h"
#include "chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.h"
-#include "components/password_manager/core/browser/password_bubble_experiment.h"
-#include "components/variations/variations_associated_data.h"
namespace {
-using password_bubble_experiment::kChromeSignInPasswordPromoExperimentName;
-using password_bubble_experiment::kChromeSignInPasswordPromoThresholdParam;
-
class SignInPromoViewControllerTest : public ManagePasswordsControllerTest {
public:
- SignInPromoViewControllerTest() : field_trial_list_(nullptr) {}
-
void SetUp() override;
void TearDown() override;
@@ -27,7 +19,6 @@ class SignInPromoViewControllerTest : public ManagePasswordsControllerTest {
SignInPromoViewController* controller() { return controller_.get(); }
private:
- base::FieldTrialList field_trial_list_;
base::scoped_nsobject<SignInPromoViewController> controller_;
};
@@ -38,17 +29,10 @@ void SignInPromoViewControllerTest::SetUp() {
void SignInPromoViewControllerTest::TearDown() {
ManagePasswordsControllerTest::TearDown();
- variations::testing::ClearAllVariationParams();
}
void SignInPromoViewControllerTest::SetUpSignInPromoState() {
- const char kFakeGroup[] = "FakeGroup";
SetUpSavePendingState(false);
- ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
- kChromeSignInPasswordPromoExperimentName, kFakeGroup));
- variations::AssociateVariationParams(
- kChromeSignInPasswordPromoExperimentName, kFakeGroup,
- {{kChromeSignInPasswordPromoThresholdParam, "3"}});
GetModelAndCreateIfNull()->OnSaveClicked();
ASSERT_TRUE(GetModelAndCreateIfNull()->ReplaceToShowPromotionIfNeeded());

Powered by Google App Engine
This is Rietveld 408576698