chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm - Issue 2653733006: Remove the Finch experiment for the sign-in promo in the password bubble.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm

Issue 2653733006: Remove the Finch experiment for the sign-in promo in the password bubble. (Closed)

Patch Set: fix mac/2 Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/passwords/passwords_bubble_controller_unittest.mm ('k') | chrome/browser/ui/cocoa/passwords/signin_promo_view_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm b/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm

index 621e3b1193a54dbcbe85f1cd62cc8e7433086fdf..6039edc8423c57eab2e30f877b7920c49d4660d7 100644

--- a/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm

@@ -13,6 +13,7 @@

#include "chrome/browser/ui/cocoa/test/cocoa_test_helper.h"

#include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"

#include "chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.h"

+#include "components/password_manager/core/common/password_manager_pref_names.h"

#include "testing/gtest/include/gtest/gtest.h"

#include "testing/gtest_mac.h"

@@ -38,6 +39,8 @@ class SavePendingPasswordViewControllerTest

TEST_F(SavePendingPasswordViewControllerTest,

ShouldSavePasswordAndDismissWhenSaveClicked) {

+ profile()->GetPrefs()->SetBoolean(

+ password_manager::prefs::kWasSignInPasswordPromoClicked, true);

SetUpSavePendingState(false);

EXPECT_CALL(*ui_controller(), SavePassword());

EXPECT_CALL(*ui_controller(), NeverSavePassword()).Times(0);