Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: chrome/browser/ui/cocoa/passwords/signin_promo_view_controller_unittest.mm

Issue 2653733006: Remove the Finch experiment for the sign-in promo in the password bubble. (Closed)
Patch Set: fix mac/2 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/passwords/signin_promo_view_controller.h" 5 #import "chrome/browser/ui/cocoa/passwords/signin_promo_view_controller.h"
6 6
7 #include "base/metrics/field_trial.h"
8 #import "chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.h" 7 #import "chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.h"
9 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.h" 8 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.h"
10 #include "components/password_manager/core/browser/password_bubble_experiment.h"
11 #include "components/variations/variations_associated_data.h"
12 9
13 namespace { 10 namespace {
14 11
15 using password_bubble_experiment::kChromeSignInPasswordPromoExperimentName;
16 using password_bubble_experiment::kChromeSignInPasswordPromoThresholdParam;
17
18 class SignInPromoViewControllerTest : public ManagePasswordsControllerTest { 12 class SignInPromoViewControllerTest : public ManagePasswordsControllerTest {
19 public: 13 public:
20 SignInPromoViewControllerTest() : field_trial_list_(nullptr) {}
21
22 void SetUp() override; 14 void SetUp() override;
23 void TearDown() override; 15 void TearDown() override;
24 16
25 void SetUpSignInPromoState(); 17 void SetUpSignInPromoState();
26 18
27 SignInPromoViewController* controller() { return controller_.get(); } 19 SignInPromoViewController* controller() { return controller_.get(); }
28 20
29 private: 21 private:
30 base::FieldTrialList field_trial_list_;
31 base::scoped_nsobject<SignInPromoViewController> controller_; 22 base::scoped_nsobject<SignInPromoViewController> controller_;
32 }; 23 };
33 24
34 void SignInPromoViewControllerTest::SetUp() { 25 void SignInPromoViewControllerTest::SetUp() {
35 ManagePasswordsControllerTest::SetUp(); 26 ManagePasswordsControllerTest::SetUp();
36 SetUpSignInPromoState(); 27 SetUpSignInPromoState();
37 } 28 }
38 29
39 void SignInPromoViewControllerTest::TearDown() { 30 void SignInPromoViewControllerTest::TearDown() {
40 ManagePasswordsControllerTest::TearDown(); 31 ManagePasswordsControllerTest::TearDown();
41 variations::testing::ClearAllVariationParams();
42 } 32 }
43 33
44 void SignInPromoViewControllerTest::SetUpSignInPromoState() { 34 void SignInPromoViewControllerTest::SetUpSignInPromoState() {
45 const char kFakeGroup[] = "FakeGroup";
46 SetUpSavePendingState(false); 35 SetUpSavePendingState(false);
47 ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
48 kChromeSignInPasswordPromoExperimentName, kFakeGroup));
49 variations::AssociateVariationParams(
50 kChromeSignInPasswordPromoExperimentName, kFakeGroup,
51 {{kChromeSignInPasswordPromoThresholdParam, "3"}});
52 GetModelAndCreateIfNull()->OnSaveClicked(); 36 GetModelAndCreateIfNull()->OnSaveClicked();
53 37
54 ASSERT_TRUE(GetModelAndCreateIfNull()->ReplaceToShowPromotionIfNeeded()); 38 ASSERT_TRUE(GetModelAndCreateIfNull()->ReplaceToShowPromotionIfNeeded());
55 39
56 [delegate() setModel:GetModelAndCreateIfNull()]; 40 [delegate() setModel:GetModelAndCreateIfNull()];
57 controller_.reset([[SignInPromoViewController alloc] 41 controller_.reset([[SignInPromoViewController alloc]
58 initWithDelegate:delegate()]); 42 initWithDelegate:delegate()]);
59 [controller_ view]; 43 [controller_ view];
60 } 44 }
61 45
(...skipping 23 matching lines...) Expand all
85 // A user may press mouse down, some navigation closes the bubble, mouse up 69 // A user may press mouse down, some navigation closes the bubble, mouse up
86 // still sends the action. 70 // still sends the action.
87 EXPECT_CALL(*ui_controller(), NavigateToChromeSignIn()).Times(0); 71 EXPECT_CALL(*ui_controller(), NavigateToChromeSignIn()).Times(0);
88 [delegate() setModel:nil]; 72 [delegate() setModel:nil];
89 [controller().signInButton performClick:nil]; 73 [controller().signInButton performClick:nil];
90 [controller().noButton performClick:nil]; 74 [controller().noButton performClick:nil];
91 [controller().closeButton performClick:nil]; 75 [controller().closeButton performClick:nil];
92 } 76 }
93 77
94 } // namespace 78 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698