Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5467)

Unified Diff: chrome/browser/ui/cocoa/passwords/passwords_bubble_controller_unittest.mm

Issue 2653733006: Remove the Finch experiment for the sign-in promo in the password bubble. (Closed)
Patch Set: fix mac/2 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/passwords/passwords_bubble_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/passwords/passwords_bubble_controller_unittest.mm b/chrome/browser/ui/cocoa/passwords/passwords_bubble_controller_unittest.mm
index 406980bf5f7923f9239e404147686a9a1622287a..9cf41d84f1a2f73c5beac2830fdafdd770c6a9ec 100644
--- a/chrome/browser/ui/cocoa/passwords/passwords_bubble_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/passwords/passwords_bubble_controller_unittest.mm
@@ -8,7 +8,6 @@
#include "base/compiler_specific.h"
#include "base/mac/foundation_util.h"
-#include "base/metrics/field_trial.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_window.h"
#import "chrome/browser/ui/cocoa/info_bubble_window.h"
@@ -20,17 +19,12 @@
#include "chrome/browser/ui/cocoa/test/cocoa_test_helper.h"
#include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"
#include "chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.h"
-#include "components/password_manager/core/browser/password_bubble_experiment.h"
-#include "components/variations/variations_associated_data.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/gtest_mac.h"
#include "testing/platform_test.h"
namespace {
-using password_bubble_experiment::kChromeSignInPasswordPromoExperimentName;
-using password_bubble_experiment::kChromeSignInPasswordPromoThresholdParam;
-
class ManagePasswordsBubbleControllerTest
: public ManagePasswordsControllerTest {
public:
@@ -94,14 +88,6 @@ TEST_F(ManagePasswordsBubbleControllerTest, ClearModelOnClose) {
}
TEST_F(ManagePasswordsBubbleControllerTest, TransitionToSignInPromo) {
- const char kFakeGroup[] = "FakeGroup";
- base::FieldTrialList field_trial_list(nullptr);
- ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
- kChromeSignInPasswordPromoExperimentName, kFakeGroup));
- variations::AssociateVariationParams(
- kChromeSignInPasswordPromoExperimentName, kFakeGroup,
- {{kChromeSignInPasswordPromoThresholdParam, "3"}});
-
SetUpSavePendingState(false);
[controller() showWindow:nil];
SavePendingPasswordViewController* saveController =
@@ -112,8 +98,6 @@ TEST_F(ManagePasswordsBubbleControllerTest, TransitionToSignInPromo) {
EXPECT_EQ([SignInPromoViewController class],
[[controller() currentController] class]);
EXPECT_TRUE([[controller() window] isVisible]);
-
- variations::testing::ClearAllVariationParams();
}
} // namespace
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698