Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2653593004: chromeos: Remove AshTestBase::SupportsMultipleDisplays (Closed)

Created:
3 years, 11 months ago by James Cook
Modified:
3 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, alemate+watch_chromium.org, sadrul, dtseng+watch_chromium.org, posciak+watch_chromium.org, achuith+watch_chromium.org, jam, nektar+watch_chromium.org, dcheng, yuzo+watch_chromium.org, aboxhall+watch_chromium.org, je_julie, darin-cc_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, devtools-reviews_chromium.org, kalyank, pfeldman, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Remove AshTestBase::SupportsMultipleDisplays This function existed to support Ash on Windows. Since we dropped Windows last year it always returns true. Eliminate it and all callers. Clean up a few unnecessary OS_CHROMEOS checks along the way. BUG=682990 TEST=compiles, ash_unittests Review-Url: https://codereview.chromium.org/2653593004 Cr-Commit-Position: refs/heads/master@{#445812} Committed: https://chromium.googlesource.com/chromium/src/+/f2ecd79007349fb621cff07448816a5c09bfd3d2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -720 lines) Patch
M ash/app_list/app_list_presenter_delegate_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/common/devtools/ash_devtools_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/common/test/ash_test.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/common/test/ash_test.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/common/test/ash_test_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/wallpaper/wallpaper_controller_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ash/common/wm/workspace/workspace_layout_manager_unittest.cc View 4 chunks +0 lines, -10 lines 0 comments Download
M ash/content/keyboard_overlay/keyboard_overlay_delegate_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/display/cursor_window_controller_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/display/display_error_observer_chromeos_unittest.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 45 chunks +0 lines, -126 lines 0 comments Download
M ash/display/display_util_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/display/extended_mouse_warp_controller_unittest.cc View 6 chunks +0 lines, -16 lines 0 comments Download
M ash/display/mouse_cursor_event_filter_unittest.cc View 5 chunks +0 lines, -15 lines 0 comments Download
M ash/display/resolution_notification_controller_unittest.cc View 8 chunks +0 lines, -24 lines 0 comments Download
M ash/display/root_window_transformers_unittest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M ash/display/screen_ash_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/display/unified_mouse_warp_controller_unittest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M ash/display/window_tree_host_manager_unittest.cc View 22 chunks +0 lines, -67 lines 0 comments Download
M ash/drag_drop/drag_drop_controller_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ash/drag_drop/drag_drop_interactive_uitest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/drag_drop/drag_drop_tracker_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ash/extended_desktop_unittest.cc View 20 chunks +0 lines, -60 lines 0 comments Download
M ash/magnifier/magnification_controller_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/magnifier/partial_magnification_controller_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/mus/test/ash_test_impl_mus.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/mus/test/ash_test_impl_mus.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/mus/test/wm_test_base.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/mus/test/wm_test_base.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/mus/top_level_window_factory_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/root_window_controller_unittest.cc View 10 chunks +0 lines, -27 lines 0 comments Download
M ash/screen_util_unittest.cc View 4 chunks +0 lines, -11 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 6 chunks +0 lines, -18 lines 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M ash/shelf/shelf_widget_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M ash/system/overview/overview_button_tray_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ash/system/toast/toast_manager_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M ash/system/web_notification/web_notification_tray_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/test/ash_test_base.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ash/test/ash_test_helper.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/test/ash_test_helper.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M ash/test/ash_test_impl_aura.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/test/ash_test_impl_aura.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/tooltips/tooltip_controller_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/touch/touch_observer_hud_unittest.cc View 7 chunks +0 lines, -21 lines 0 comments Download
M ash/utility/screenshot_controller_unittest.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager_unittest.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/wm/drag_window_resizer_unittest.cc View 7 chunks +0 lines, -20 lines 0 comments Download
M ash/wm/immersive_fullscreen_controller_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/wm/lock_layout_manager_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_controller_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 6 chunks +0 lines, -18 lines 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 4 chunks +0 lines, -12 lines 0 comments Download
M ash/wm/panels/panel_window_resizer_unittest.cc View 6 chunks +0 lines, -18 lines 0 comments Download
M ash/wm/system_modal_container_layout_manager_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ash/wm/toplevel_window_event_handler_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/wm/video_detector_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/wm/window_cycle_controller_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/wm/window_positioner_unittest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M ash/wm/window_state_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/wm/window_util_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 4 chunks +0 lines, -10 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 4 chunks +1 line, -13 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc View 8 chunks +0 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/ui/accessibility_focus_ring_controller_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/display/manager/display_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
James Cook
sky, PTAL.
3 years, 11 months ago (2017-01-24 03:16:54 UTC) #7
sky
LGTM
3 years, 11 months ago (2017-01-24 17:51:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653593004/1
3 years, 11 months ago (2017-01-24 20:51:18 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 21:17:31 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f2ecd79007349fb621cff0744881...

Powered by Google App Engine
This is Rietveld 408576698