Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Unified Diff: ash/extended_desktop_unittest.cc

Issue 2653593004: chromeos: Remove AshTestBase::SupportsMultipleDisplays (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/drag_drop/drag_drop_tracker_unittest.cc ('k') | ash/magnifier/magnification_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/extended_desktop_unittest.cc
diff --git a/ash/extended_desktop_unittest.cc b/ash/extended_desktop_unittest.cc
index 001902b64faee2a8167da2c48948a91eed89977e..8747c721070012c61da6e4e5bba716ef35ce8f68 100644
--- a/ash/extended_desktop_unittest.cc
+++ b/ash/extended_desktop_unittest.cc
@@ -168,9 +168,6 @@ class ExtendedDesktopTest : public test::AshTestBase {
// Test conditions that root windows in extended desktop mode
// must satisfy.
TEST_F(ExtendedDesktopTest, Basic) {
- if (!SupportsMultipleDisplays())
- return;
-
UpdateDisplay("1000x600,600x400");
aura::Window::Windows root_windows = Shell::GetAllRootWindows();
@@ -190,9 +187,6 @@ TEST_F(ExtendedDesktopTest, Basic) {
}
TEST_F(ExtendedDesktopTest, Activation) {
- if (!SupportsMultipleDisplays())
- return;
-
UpdateDisplay("1000x600,600x400");
aura::Window::Windows root_windows = Shell::GetAllRootWindows();
@@ -224,9 +218,6 @@ TEST_F(ExtendedDesktopTest, Activation) {
}
TEST_F(ExtendedDesktopTest, SystemModal) {
- if (!SupportsMultipleDisplays())
- return;
-
UpdateDisplay("1000x600,600x400");
aura::Window::Windows root_windows = Shell::GetAllRootWindows();
@@ -261,9 +252,6 @@ TEST_F(ExtendedDesktopTest, SystemModal) {
}
TEST_F(ExtendedDesktopTest, TestCursor) {
- if (!SupportsMultipleDisplays())
- return;
-
UpdateDisplay("1000x600,600x400");
aura::Window::Windows root_windows = Shell::GetAllRootWindows();
aura::WindowTreeHost* host0 = root_windows[0]->GetHost();
@@ -276,9 +264,6 @@ TEST_F(ExtendedDesktopTest, TestCursor) {
}
TEST_F(ExtendedDesktopTest, TestCursorLocation) {
- if (!SupportsMultipleDisplays())
- return;
-
UpdateDisplay("1000x600,600x400");
aura::Window::Windows root_windows = Shell::GetAllRootWindows();
aura::test::WindowTestApi root_window0_test_api(root_windows[0]);
@@ -302,9 +287,6 @@ TEST_F(ExtendedDesktopTest, TestCursorLocation) {
}
TEST_F(ExtendedDesktopTest, GetRootWindowAt) {
- if (!SupportsMultipleDisplays())
- return;
-
UpdateDisplay("700x500,500x500");
SetSecondaryDisplayLayout(display::DisplayPlacement::LEFT);
aura::Window::Windows root_windows = Shell::GetAllRootWindows();
@@ -330,9 +312,6 @@ TEST_F(ExtendedDesktopTest, GetRootWindowAt) {
}
TEST_F(ExtendedDesktopTest, GetRootWindowMatching) {
- if (!SupportsMultipleDisplays())
- return;
-
UpdateDisplay("700x500,500x500");
SetSecondaryDisplayLayout(display::DisplayPlacement::LEFT);
@@ -370,9 +349,6 @@ TEST_F(ExtendedDesktopTest, GetRootWindowMatching) {
}
TEST_F(ExtendedDesktopTest, Capture) {
- if (!SupportsMultipleDisplays())
- return;
-
UpdateDisplay("1000x600,600x400");
aura::Window::Windows root_windows = Shell::GetAllRootWindows();
@@ -440,9 +416,6 @@ TEST_F(ExtendedDesktopTest, Capture) {
}
TEST_F(ExtendedDesktopTest, CaptureEventLocation) {
- if (!SupportsMultipleDisplays())
- return;
-
UpdateDisplay("1000x600,600x400");
aura::Window::Windows root_windows = Shell::GetAllRootWindows();
@@ -475,9 +448,6 @@ TEST_F(ExtendedDesktopTest, CaptureEventLocation) {
}
TEST_F(ExtendedDesktopTest, CaptureEventLocationHighDPI) {
- if (!SupportsMultipleDisplays())
- return;
-
UpdateDisplay("1000x600*2,600x400");
aura::Window::Windows root_windows = Shell::GetAllRootWindows();
@@ -510,9 +480,6 @@ TEST_F(ExtendedDesktopTest, CaptureEventLocationHighDPI) {
}
TEST_F(ExtendedDesktopTest, CaptureEventLocationHighDPI_2) {
- if (!SupportsMultipleDisplays())
- return;
-
UpdateDisplay("1000x600,600x400*2");
aura::Window::Windows root_windows = Shell::GetAllRootWindows();
@@ -549,9 +516,6 @@ TEST_F(ExtendedDesktopTest, CaptureEventLocationHighDPI_2) {
}
TEST_F(ExtendedDesktopTest, MoveWindow) {
- if (!SupportsMultipleDisplays())
- return;
-
UpdateDisplay("1000x600,600x400");
aura::Window::Windows root_windows = Shell::GetAllRootWindows();
views::Widget* d1 = CreateTestWidget(gfx::Rect(10, 10, 100, 100));
@@ -583,9 +547,6 @@ TEST_F(ExtendedDesktopTest, MoveWindow) {
// Verifies if the mouse event arrives to the window even when the window
// moves to another root in a pre-target handler. See: crbug.com/157583
TEST_F(ExtendedDesktopTest, MoveWindowByMouseClick) {
- if (!SupportsMultipleDisplays())
- return;
-
UpdateDisplay("1000x600,600x400");
aura::Window::Windows root_windows = Shell::GetAllRootWindows();
@@ -606,9 +567,6 @@ TEST_F(ExtendedDesktopTest, MoveWindowByMouseClick) {
}
TEST_F(ExtendedDesktopTest, MoveWindowToDisplay) {
- if (!SupportsMultipleDisplays())
- return;
-
UpdateDisplay("1000x1000,1000x1000");
aura::Window::Windows root_windows = Shell::GetAllRootWindows();
@@ -636,9 +594,6 @@ TEST_F(ExtendedDesktopTest, MoveWindowToDisplay) {
}
TEST_F(ExtendedDesktopTest, MoveWindowWithTransient) {
- if (!SupportsMultipleDisplays())
- return;
-
UpdateDisplay("1000x600,600x400");
aura::Window::Windows root_windows = Shell::GetAllRootWindows();
views::Widget* w1 = CreateTestWidget(gfx::Rect(10, 10, 100, 100));
@@ -685,10 +640,7 @@ TEST_F(ExtendedDesktopTest, MoveWindowWithTransient) {
}
// Test if the Window::ConvertPointToTarget works across root windows.
-// TODO(oshima): Move multiple display suport and this test to aura.
TEST_F(ExtendedDesktopTest, ConvertPoint) {
- if (!SupportsMultipleDisplays())
- return;
display::Screen* screen = display::Screen::GetScreen();
UpdateDisplay("1000x600,600x400");
aura::Window::Windows root_windows = Shell::GetAllRootWindows();
@@ -744,9 +696,6 @@ TEST_F(ExtendedDesktopTest, ConvertPoint) {
}
TEST_F(ExtendedDesktopTest, OpenSystemTray) {
- if (!SupportsMultipleDisplays())
- return;
-
UpdateDisplay("500x600,600x400");
SystemTray* tray = ash::Shell::GetInstance()->GetPrimarySystemTray();
ASSERT_FALSE(tray->HasSystemBubble());
@@ -778,9 +727,6 @@ TEST_F(ExtendedDesktopTest, OpenSystemTray) {
}
TEST_F(ExtendedDesktopTest, StayInSameRootWindow) {
- if (!SupportsMultipleDisplays())
- return;
-
UpdateDisplay("100x100,200x200");
aura::Window::Windows root_windows = Shell::GetAllRootWindows();
views::Widget* w1 = CreateTestWidget(gfx::Rect(10, 10, 50, 50));
@@ -819,9 +765,6 @@ TEST_F(ExtendedDesktopTest, StayInSameRootWindow) {
}
TEST_F(ExtendedDesktopTest, KeyEventsOnLockScreen) {
- if (!SupportsMultipleDisplays())
- return;
-
UpdateDisplay("100x100,200x200");
aura::Window::Windows root_windows = Shell::GetAllRootWindows();
@@ -892,9 +835,6 @@ TEST_F(ExtendedDesktopTest, KeyEventsOnLockScreen) {
}
TEST_F(ExtendedDesktopTest, PassiveGrab) {
- if (!SupportsMultipleDisplays())
- return;
-
EventLocationRecordingEventHandler event_handler;
ash::Shell::GetInstance()->AddPreTargetHandler(&event_handler);
« no previous file with comments | « ash/drag_drop/drag_drop_tracker_unittest.cc ('k') | ash/magnifier/magnification_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698