VM: Fix asan memory leak in some standalone tests

runtime/bin/directory.h

Index: runtime/bin/directory.h
diff --git a/runtime/bin/directory.h b/runtime/bin/directory.h
index 86026b7300eba7d5efbff23619842f5a17cc1713..788a597e50392a4805a1baad9a8218555725407b 100644
--- a/runtime/bin/directory.h
+++ b/runtime/bin/directory.h
@@ -193,10 +193,13 @@ class AsyncDirectoryListing : public ReferenceCounted<AsyncDirectoryListing>,
 class SyncDirectoryListing : public DirectoryListing {
  public:
   SyncDirectoryListing(Dart_Handle results,
+                       Dart_Handle* dart_error,
                        const char* dir_name,
                        bool recursive,
                        bool follow_links)
-      : DirectoryListing(dir_name, recursive, follow_links), results_(results) {
+      : DirectoryListing(dir_name, recursive, follow_links),
+        results_(results),
+        dart_error_(dart_error) {
     add_string_ = DartUtils::NewString("add");
     directory_type_ = DartUtils::GetDartType(DartUtils::kIOLibURL, "Directory");
     file_type_ = DartUtils::GetDartType(DartUtils::kIOLibURL, "File");
@@ -214,6 +217,7 @@ class SyncDirectoryListing : public DirectoryListing {
   Dart_Handle directory_type_;
   Dart_Handle file_type_;
   Dart_Handle link_type_;
+  Dart_Handle* dart_error_;

[zra, 2017/01/23 17:04:51]

DBC:

Why is this a pointer? Why can't it be a regular field with setter/getter?

[kustermann, 2017/01/23 18:45:32]

I made it a pointer to avoid an uninitialized variable on the call site.

But if you have a different preference, I change it of course!

[zra, 2017/01/23 18:53:15]

Not sure what you mean by this. What call site?

[kustermann, 2017/01/23 18:55:44]

Line 128 here 
https://codereview.chromium.org/2653583002/diff/40001/runtime/bin/directory.cc

 
   DISALLOW_ALLOCATION()
   DISALLOW_IMPLICIT_CONSTRUCTORS(SyncDirectoryListing);