VM: Fix asan memory leak in some standalone tests

runtime/bin/directory.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #if !defined(DART_IO_DISABLED)
 
 #include "bin/directory.h"
 
 #include "bin/dartutils.h"
 #include "bin/log.h"
@@ skipping 106 matching lines @@
 }
 
 
 void FUNCTION_NAME(Directory_FillWithDirectoryListing)(
     Dart_NativeArguments args) {
   // The list that we should fill.
   Dart_Handle results = Dart_GetNativeArgument(args, 0);
   Dart_Handle path = Dart_GetNativeArgument(args, 1);
   Dart_Handle recursive = Dart_GetNativeArgument(args, 2);
   Dart_Handle follow_links = Dart_GetNativeArgument(args, 3);
-  // Pass the list that should hold the directory listing to the
-  // SyncDirectoryListing object, which adds elements to it.
-  SyncDirectoryListing sync_listing(results, DartUtils::GetStringValue(path),
-                                    DartUtils::GetBooleanValue(recursive),
-                                    DartUtils::GetBooleanValue(follow_links));
-  Directory::List(&sync_listing);
+
+  Dart_Handle dart_error;
+  {
+    // Pass the list that should hold the directory listing to the
+    // SyncDirectoryListing object, which adds elements to it.
+    SyncDirectoryListing sync_listing(results, DartUtils::GetStringValue(path),
+                                      DartUtils::GetBooleanValue(recursive),
+                                      DartUtils::GetBooleanValue(follow_links));
+    Directory::List(&sync_listing);
+    dart_error = sync_listing.dart_error();
+  }
+  if (Dart_IsError(dart_error)) {
+    Dart_PropagateError(dart_error);
+  } else if (!Dart_IsNull(dart_error)) {
+    Dart_ThrowException(dart_error);
+  }
 }
 
 
 static const int kAsyncDirectoryListerFieldIndex = 0;
 
 
 void FUNCTION_NAME(Directory_GetAsyncDirectoryListerPointer)(
     Dart_NativeArguments args) {
   AsyncDirectoryListing* listing;
   Dart_Handle dart_this = ThrowIfError(Dart_GetNativeArgument(args, 0));
@@ skipping 251 matching lines @@
   array_->SetAt(index_++, response);
   return index_ < length_;
 }
 
 
 bool SyncDirectoryListing::HandleDirectory(const char* dir_name) {
   Dart_Handle dir_name_dart = DartUtils::NewString(dir_name);
   Dart_Handle dir = Dart_New(directory_type_, Dart_Null(), 1, &dir_name_dart);
   Dart_Handle result = Dart_Invoke(results_, add_string_, 1, &dir);
   if (Dart_IsError(result)) {
-    Dart_PropagateError(result);
+    dart_error_ = result;
+    return false;
   }
   return true;
 }
 
 
 bool SyncDirectoryListing::HandleLink(const char* link_name) {
   Dart_Handle link_name_dart = DartUtils::NewString(link_name);
   Dart_Handle link = Dart_New(link_type_, Dart_Null(), 1, &link_name_dart);
   Dart_Handle result = Dart_Invoke(results_, add_string_, 1, &link);
   if (Dart_IsError(result)) {
-    Dart_PropagateError(result);
+    dart_error_ = result;
+    return false;
   }
   return true;
 }
 
 
 bool SyncDirectoryListing::HandleFile(const char* file_name) {
   Dart_Handle file_name_dart = DartUtils::NewString(file_name);
   Dart_Handle file = Dart_New(file_type_, Dart_Null(), 1, &file_name_dart);
   Dart_Handle result = Dart_Invoke(results_, add_string_, 1, &file);
   if (Dart_IsError(result)) {
-    Dart_PropagateError(result);
+    dart_error_ = result;
+    return false;
   }
   return true;
 }
 
 
 bool SyncDirectoryListing::HandleError() {
   Dart_Handle dart_os_error = DartUtils::NewDartOSError();
   Dart_Handle args[3];
   args[0] = DartUtils::NewString("Directory listing failed");
   args[1] = DartUtils::NewString(error() ? "Invalid path" : CurrentPath());
   args[2] = dart_os_error;
-  Dart_ThrowException(Dart_New(
+
+  dart_error_ = Dart_New(
       DartUtils::GetDartType(DartUtils::kIOLibURL, "FileSystemException"),
-      Dart_Null(), 3, args));
-  return true;
+      Dart_Null(), 3, args);
+  return false;
 }
 
 
 static bool ListNext(DirectoryListing* listing) {
   switch (listing->top()->Next(listing)) {
     case kListFile:
       return listing->HandleFile(listing->CurrentPath());
 
     case kListLink:
       return listing->HandleLink(listing->CurrentPath());
@@ skipping 30 matching lines @@
   } else {
     while (ListNext(listing)) {
     }
   }
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // !defined(DART_IO_DISABLED)