VM: Fix asan memory leak in some standalone tests

runtime/bin/directory.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef RUNTIME_BIN_DIRECTORY_H_
 #define RUNTIME_BIN_DIRECTORY_H_
 
 #include "bin/builtin.h"
 #include "bin/dartutils.h"
 #include "bin/reference_counting.h"
@@ skipping 175 matching lines @@
   intptr_t length_;
 
   friend class ReferenceCounted<AsyncDirectoryListing>;
   DISALLOW_IMPLICIT_CONSTRUCTORS(AsyncDirectoryListing);
 };
 
 
 class SyncDirectoryListing : public DirectoryListing {
  public:
   SyncDirectoryListing(Dart_Handle results,
+                       Dart_Handle* dart_error,
                        const char* dir_name,
                        bool recursive,
                        bool follow_links)
-      : DirectoryListing(dir_name, recursive, follow_links), results_(results) {
+      : DirectoryListing(dir_name, recursive, follow_links),
+        results_(results),
+        dart_error_(dart_error) {
     add_string_ = DartUtils::NewString("add");
     directory_type_ = DartUtils::GetDartType(DartUtils::kIOLibURL, "Directory");
     file_type_ = DartUtils::GetDartType(DartUtils::kIOLibURL, "File");
     link_type_ = DartUtils::GetDartType(DartUtils::kIOLibURL, "Link");
   }
   virtual ~SyncDirectoryListing() {}
   virtual bool HandleDirectory(const char* dir_name);
   virtual bool HandleFile(const char* file_name);
   virtual bool HandleLink(const char* file_name);
   virtual bool HandleError();
 
  private:
   Dart_Handle results_;
   Dart_Handle add_string_;
   Dart_Handle directory_type_;
   Dart_Handle file_type_;
   Dart_Handle link_type_;
+  Dart_Handle* dart_error_;

[zra, 2017/01/23 17:04:51]

DBC:

Why is this a pointer? Why can't it be a regular field with setter/getter?

[kustermann, 2017/01/23 18:45:32]

I made it a pointer to avoid an uninitialized variable on the call site.

But if you have a different preference, I change it of course!

[zra, 2017/01/23 18:53:15]

Not sure what you mean by this. What call site?

[kustermann, 2017/01/23 18:55:44]

Line 128 here 
https://codereview.chromium.org/2653583002/diff/40001/runtime/bin/directory.cc

 
   DISALLOW_ALLOCATION()
   DISALLOW_IMPLICIT_CONSTRUCTORS(SyncDirectoryListing);
 };
 
 
 class Directory {
  public:
   enum ExistsResult { UNKNOWN, EXISTS, DOES_NOT_EXIST };
 
@@ skipping 29 matching lines @@
  private:
   static char* system_temp_path_override_;
   DISALLOW_ALLOCATION();
   DISALLOW_IMPLICIT_CONSTRUCTORS(Directory);
 };
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // RUNTIME_BIN_DIRECTORY_H_