Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: content/common/service_worker/service_worker.mojom

Issue 2653493009: Add two interfaces for ServiceWorkerProviderContext/ProviderHost (Closed)
Patch Set: Rebased/Fixed unittests when BrowserSideNavigation is enabled Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/service_worker/service_worker.mojom
diff --git a/content/common/service_worker/service_worker.mojom b/content/common/service_worker/service_worker.mojom
index cadade0e8bc56d62b1f5ab18a0140839200d2d83..c5523d7e3b1501935ba3f0fb100913139f22d3f2 100644
--- a/content/common/service_worker/service_worker.mojom
+++ b/content/common/service_worker/service_worker.mojom
@@ -10,8 +10,11 @@ import "content/common/service_worker/service_worker_provider.mojom";
// Each InterfacePtrs on the same render process will be bound to the same
falken 2017/05/18 04:13:10 All InterfacePtrs on the same renderer process are
shimazu 2017/05/19 08:31:07 Done.
// ServiceWorkerDispatcherHost.
falken 2017/05/18 04:13:09 Add sentence like: The renderer uses this interfac
shimazu 2017/05/19 08:31:07 Done.
interface ServiceWorkerDispatcherHost {
+ // Creates a ServiceWorkerProviderHost on the browser process. |provider_info|
+ // have mojo endpoints to connect the provider host and the provider on the
falken 2017/05/18 04:13:10 has Mojo endpoints
shimazu 2017/05/19 08:31:06 Done.
+ // renderer together. The lifetime of ServiceWorkerProviderHost will be
+ // managed with the interface.
falken 2017/05/18 04:13:10 "managed with the interface" -> "tied to this mojo
shimazu 2017/05/19 08:31:07 Done.
OnProviderCreated(ServiceWorkerProviderHostInfo provider_info);
- OnProviderDestroyed(int32 provider_id);
// Informs the browser that a service worker is starting up. |provider_id|
// identifies the ServiceWorkerProviderHost hosting the service

Powered by Google App Engine
This is Rietveld 408576698