Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Unified Diff: content/child/service_worker/service_worker_provider_context.h

Issue 2653493009: Add two interfaces for ServiceWorkerProviderContext/ProviderHost (Closed)
Patch Set: Rebased/Fixed unittests when BrowserSideNavigation is enabled Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/service_worker/service_worker_provider_context.h
diff --git a/content/child/service_worker/service_worker_provider_context.h b/content/child/service_worker/service_worker_provider_context.h
index 192be968692b86a8b7e28e4e62823dd9cc1015ae..3c88a7a852886025e365e8fa33b83c068709dd0b 100644
--- a/content/child/service_worker/service_worker_provider_context.h
+++ b/content/child/service_worker/service_worker_provider_context.h
@@ -13,7 +13,9 @@
#include "base/memory/ref_counted.h"
#include "base/sequenced_task_runner_helpers.h"
#include "content/common/content_export.h"
+#include "content/common/service_worker/service_worker_provider_interfaces.mojom.h"
#include "content/common/service_worker/service_worker_types.h"
+#include "mojo/public/cpp/bindings/associated_binding.h"
namespace base {
class SingleThreadTaskRunner;
@@ -44,11 +46,14 @@ class ThreadSafeSender;
// ControlleeDelegate and ControllerDelegate.
class CONTENT_EXPORT ServiceWorkerProviderContext
: public base::RefCountedThreadSafe<ServiceWorkerProviderContext,
- ServiceWorkerProviderContextDeleter> {
+ ServiceWorkerProviderContextDeleter>,
+ NON_EXPORTED_BASE(public mojom::ServiceWorkerProvider) {
public:
falken 2017/05/18 04:13:09 Can you document what |request| is?
shimazu 2017/05/19 08:31:06 Done.
- ServiceWorkerProviderContext(int provider_id,
- ServiceWorkerProviderType provider_type,
- ThreadSafeSender* thread_safe_sender);
+ ServiceWorkerProviderContext(
+ int provider_id,
+ ServiceWorkerProviderType provider_type,
+ mojom::ServiceWorkerProviderAssociatedRequest request,
+ ThreadSafeSender* thread_safe_sender);
// Called from ServiceWorkerDispatcher.
void OnAssociateRegistration(
@@ -84,12 +89,13 @@ class CONTENT_EXPORT ServiceWorkerProviderContext
class ControlleeDelegate;
class ControllerDelegate;
- ~ServiceWorkerProviderContext();
+ ~ServiceWorkerProviderContext() override;
void DestructOnMainThread() const;
const int provider_id_;
scoped_refptr<base::SingleThreadTaskRunner> main_thread_task_runner_;
scoped_refptr<ThreadSafeSender> thread_safe_sender_;
+ mojo::AssociatedBinding<mojom::ServiceWorkerProvider> binding_;
std::unique_ptr<Delegate> delegate_;

Powered by Google App Engine
This is Rietveld 408576698