Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1472)

Issue 2653223005: Move views vector icons from source_set to part of views target. (Closed)

Created:
3 years, 10 months ago by Evan Stade
Modified:
3 years, 10 months ago
Reviewers:
sky, Dan Beam
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move views vector icons from source_set to part of views target. This matches the pattern used for components/ vector icons (see https://codereview.chromium.org/2644903004/ ) and fixes an ODR violation. BUG=684911 Review-Url: https://codereview.chromium.org/2653223005 Cr-Commit-Position: refs/heads/master@{#446772} Committed: https://chromium.googlesource.com/chromium/src/+/d34536f5fddb8e11e0e24c12326f5f8523cbf98c

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -284 lines) Patch
M chrome/browser/ui/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_sheet_view_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/BUILD.gn View 4 chunks +51 lines, -1 line 0 comments Download
M ui/views/controls/button/checkbox.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/radio_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_image_util.cc View 1 chunk +1 line, -1 line 0 comments Download
D ui/views/resources/vector_icons/BUILD.gn View 1 chunk +0 lines, -64 lines 0 comments Download
D ui/views/resources/vector_icons/checkbox_active.icon View 1 chunk +0 lines, -16 lines 0 comments Download
D ui/views/resources/vector_icons/checkbox_normal.icon View 1 chunk +0 lines, -22 lines 0 comments Download
D ui/views/resources/vector_icons/combobox_arrow_mac_disabled.icon View 1 chunk +0 lines, -17 lines 0 comments Download
D ui/views/resources/vector_icons/combobox_arrow_mac_enabled.icon View 1 chunk +0 lines, -27 lines 0 comments Download
D ui/views/resources/vector_icons/menu_check.icon View 1 chunk +0 lines, -14 lines 0 comments Download
D ui/views/resources/vector_icons/menu_check.1x.icon View 1 chunk +0 lines, -14 lines 0 comments Download
D ui/views/resources/vector_icons/menu_radio_empty.icon View 1 chunk +0 lines, -8 lines 0 comments Download
D ui/views/resources/vector_icons/menu_radio_selected.icon View 1 chunk +0 lines, -9 lines 0 comments Download
D ui/views/resources/vector_icons/radio_button_active.icon View 1 chunk +0 lines, -9 lines 0 comments Download
D ui/views/resources/vector_icons/radio_button_normal.icon View 1 chunk +0 lines, -8 lines 0 comments Download
D ui/views/resources/vector_icons/submenu_arrow.icon View 1 chunk +0 lines, -12 lines 0 comments Download
D ui/views/resources/vector_icons/submenu_arrow.1x.icon View 1 chunk +0 lines, -12 lines 0 comments Download
D ui/views/resources/vector_icons/vector_icons.cc.template View 1 chunk +0 lines, -25 lines 0 comments Download
D ui/views/resources/vector_icons/vector_icons.h.template View 1 1 chunk +0 lines, -28 lines 0 comments Download
A + ui/views/vector_icons/checkbox_active.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/vector_icons/checkbox_normal.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/vector_icons/combobox_arrow_mac_disabled.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/vector_icons/combobox_arrow_mac_enabled.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/vector_icons/menu_check.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/vector_icons/menu_check.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/vector_icons/menu_radio_empty.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/vector_icons/menu_radio_selected.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/vector_icons/radio_button_active.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/vector_icons/radio_button_normal.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/vector_icons/submenu_arrow.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/vector_icons/submenu_arrow.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/vector_icons/vector_icons.cc.template View 1 chunk +1 line, -1 line 0 comments Download
A + ui/views/vector_icons/vector_icons.h.template View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Evan Stade
3 years, 10 months ago (2017-01-26 15:35:48 UTC) #7
sky
LGTM
3 years, 10 months ago (2017-01-26 18:38:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653223005/20001
3 years, 10 months ago (2017-01-27 19:28:06 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/d34536f5fddb8e11e0e24c12326f5f8523cbf98c
3 years, 10 months ago (2017-01-27 21:18:32 UTC) #16
Dan Beam
3 years, 10 months ago (2017-01-27 22:07:57 UTC) #18
Message was sent while issue was closed.
there was a leftover /resources/ path on Mac lying around, I've removed it here:
https://codereview.chromium.org/2659133002/

if that doesn't fix the Mac compile, we may need to revert both

Powered by Google App Engine
This is Rietveld 408576698