third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc - Issue 2653123002: Changed EClear to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

Issue 2653123002: Changed EClear to an enum class and renamed its members (Closed)

Patch Set: Rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc ('k') | third_party/WebKit/Source/core/style/ComputedStyle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

index ff6037876771a56e5072a54a29d8c6acb6950821..8a3bf3953a47c5db2281213f1ad74aadf33c0260 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

@@ -1115,7 +1115,7 @@ TEST_F(NGBlockLayoutAlgorithmTest, DISABLED_PositionFragmentsWithClear) {

};

// clear: none

- run_with_clearance(EClear::ClearNone);

+ run_with_clearance(EClear::kNone);

// 20 = std::max(body's margin 8, clearance's margins 20)

EXPECT_EQ(LayoutUnit(20), body_fragment->TopOffset());

EXPECT_EQ(LayoutUnit(0), container_fragment->TopOffset());

@@ -1129,7 +1129,7 @@ TEST_F(NGBlockLayoutAlgorithmTest, DISABLED_PositionFragmentsWithClear) {

EXPECT_EQ(LayoutUnit(200), adjoining_clearance_fragment->TopOffset());

// clear: right

- run_with_clearance(EClear::ClearRight);

+ run_with_clearance(EClear::kRight);

// 8 = body's margin. This doesn't collapse its margins with 'clearance' block

// as it's not an adjoining block to body.

EXPECT_EQ(LayoutUnit(8), body_fragment->TopOffset());

@@ -1144,7 +1144,7 @@ TEST_F(NGBlockLayoutAlgorithmTest, DISABLED_PositionFragmentsWithClear) {

EXPECT_EQ(LayoutUnit(370), adjoining_clearance_fragment->TopOffset());

// clear: left

- run_with_clearance(EClear::ClearLeft);

+ run_with_clearance(EClear::kLeft);

// 8 = body's margin. This doesn't collapse its margins with 'clearance' block

// as it's not an adjoining block to body.

EXPECT_EQ(LayoutUnit(8), body_fragment->TopOffset());

@@ -1160,7 +1160,7 @@ TEST_F(NGBlockLayoutAlgorithmTest, DISABLED_PositionFragmentsWithClear) {

// clear: both

// same as clear: right

- run_with_clearance(EClear::ClearBoth);

+ run_with_clearance(EClear::kBoth);

EXPECT_EQ(LayoutUnit(8), body_fragment->TopOffset());

EXPECT_EQ(LayoutUnit(0), container_fragment->TopOffset());

EXPECT_EQ(LayoutUnit(170), clerance_fragment->TopOffset());