Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2653043002: Fix Feature Policy header replication in site-isolation. (Closed)

Created:
3 years, 11 months ago by iclelland
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Fix Feature Policy header replication in site-isolation. The ToWebParsedFeaturePolicy method was not constructing the WebParsedFeaturePolicy struct correctly, so remote frames would only receive empty whitelists when the FP header was replicated from their local process. BUG=683199, 672546 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2644233005 Cr-Commit-Position: refs/heads/master@{#445714} (cherry picked from commit 6fafd01c2b16b4c4b23e3fb83c80722f36a3bb14) Review-Url: https://codereview.chromium.org/2653043002 . Cr-Commit-Position: refs/branch-heads/2987@{#66} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/2cd339129aa18e64658b1f15f37a53789dab5b68

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M content/renderer/render_frame_proxy.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
iclelland
3 years, 11 months ago (2017-01-24 19:18:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2cd339129aa18e64658b1f15f37a53789dab5b68.

Powered by Google App Engine
This is Rietveld 408576698