Fix Feature Policy header replication in site-isolation.

Fix Feature Policy header replication in site-isolation.

The ToWebParsedFeaturePolicy method was not constructing the
WebParsedFeaturePolicy struct correctly, so remote frames would only receive
empty whitelists when the FP header was replicated from their local process.

BUG=683199, 672546
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2644233005
Cr-Commit-Position: refs/heads/master@{#445714}
Committed: https://chromium.googlesource.com/chromium/src/+/6fafd01c2b16b4c4b23e3fb83c80722f36a3bb14

[iclelland, 2017-01-20 20:53:18]

The CQ bit was checked by iclelland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 20:53:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 22:05:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 22:05:35]

Dry run: This issue passed the CQ dry run.

[iclelland, 2017-01-21 03:42:31]

The CQ bit was checked by iclelland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-21 03:42:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 03:45:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 03:45:28]

Dry run: This issue passed the CQ dry run.

[iclelland, 2017-01-23 16:17:37]

The CQ bit was checked by iclelland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 16:17:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 16:18:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 16:18:42]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[iclelland, 2017-01-23 21:37:42]

iclelland@chromium.org changed reviewers:
+ alexmos@chromium.org

[iclelland, 2017-01-23 21:37:42]

+r alexmos, can you PTAL?

This line was missing from https://codereview.chromium.org/2483703002, which
should have been caught by site-isolation bots, but wasn't for some reason.
Tests started failing once the feature was used, so there is coverage now, at
least.

The CL also re-enables the failing tests on the site-isolation builders.

[alexmos, 2017-01-23 21:56:54]

LGTM.  Yikes, thanks for fixing this, and glad we have the test coverage now.

[Charlie Reis, 2017-01-23 23:26:10]

Description was changed from

==========
Fix Feature Policy header replication in site-isolation.

The ToWebParsedFeaturePolicy method was not constructing the
WebParsedFeaturePolicy struct correctly, so remote frames would only receive
empty whitelists when the FP header was replicated from their local process.

BUG=683199,672546
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Fix Feature Policy header replication in site-isolation.

The ToWebParsedFeaturePolicy method was not constructing the
WebParsedFeaturePolicy struct correctly, so remote frames would only receive
empty whitelists when the FP header was replicated from their local process.

BUG=683199,672546
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[iclelland, 2017-01-24 14:08:15]

The CQ bit was checked by iclelland@chromium.org

[commit-bot: I haz the power, 2017-01-24 14:08:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 14:11:59]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485266895636130,
"parent_rev": "147224e62101ce267cb1c01129c1d98e38b8e171", "commit_rev":
"6fafd01c2b16b4c4b23e3fb83c80722f36a3bb14"}

[commit-bot: I haz the power, 2017-01-24 14:12:31]

Description was changed from

==========
Fix Feature Policy header replication in site-isolation.

The ToWebParsedFeaturePolicy method was not constructing the
WebParsedFeaturePolicy struct correctly, so remote frames would only receive
empty whitelists when the FP header was replicated from their local process.

BUG=683199,672546
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Fix Feature Policy header replication in site-isolation.

The ToWebParsedFeaturePolicy method was not constructing the
WebParsedFeaturePolicy struct correctly, so remote frames would only receive
empty whitelists when the FP header was replicated from their local process.

BUG=683199,672546
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2644233005
Cr-Commit-Position: refs/heads/master@{#445714}
Committed:
https://chromium.googlesource.com/chromium/src/+/6fafd01c2b16b4c4b23e3fb83c80...
==========

[commit-bot: I haz the power, 2017-01-24 14:12:32]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6fafd01c2b16b4c4b23e3fb83c80...