Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2652893012: Remove RenderWidgetHostImpl::SuppressEventsUntilKeyDown() (Closed)

Created:
3 years, 11 months ago by foolip
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Remove RenderWidgetHostImpl::SuppressEventsUntilKeyDown() This revert https://codereview.chromium.org/12221133 where the suppression on focus was originally added. No tests were added, but the manual test described now passes without this code. There is of course some chance that it is needed for some other case, so this CL should be revert at the first sign of trouble. The reason for this change is that the suppression on focus causes the PrintScreen KeyUp event to be dropped. BUG=668969 Review-Url: https://codereview.chromium.org/2643243002 Cr-Commit-Position: refs/heads/master@{#446023} (cherry picked from commit e5fd75af8171718a84d387486cfba0ed225c6f5f) Review-Url: https://codereview.chromium.org/2652893012 . Cr-Commit-Position: refs/branch-heads/2987@{#109} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/eef386e8b37005016c26e10e839e8984b98ad4da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
foolip
3 years, 11 months ago (2017-01-26 17:51:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eef386e8b37005016c26e10e839e8984b98ad4da.

Powered by Google App Engine
This is Rietveld 408576698