Prevent translated key events (WM_CHAR) associated with key events that focus the WebContents fro...

Prevent translated key events (WM_CHAR) associated with key events that focus the WebContents from being sent to the renderer, as they are not intended to target the renderer.

Example:

When the focus is in the omnibox, and a new URL is typed and Enter is pressed, the Enter keypress should focus the WebContents but the WebContents should not send the Enter char event to the current page.

BUG=175634
TEST=open print preview, select "save as pdf" as the destination and then navigate in the url bar by typing a url then enter. The "choose file" dialog shouldn't come up.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181958

[jam, 2013-02-12 06:10:12]

There are multiple ways of fixing this, I'm sending this as a proposal since I'm
not very familiar with this area.

I could have avoided adding a new method to RenderWidgetHostImpl, and instead
just done it in GotFocus or one of the other RWHI methods that
RenderWidgetHostViewAura::OnWindowFocused calls. But that seems not as clear,
since the other methods are also called on other platforms which don't need
this.

Or perhaps the views/aura/ui layers should know that when the TextInputClient
changes in the middle of processing a keydown event that the char event
shouldn't be propagated to the new TextInputClient?

[Ben Goodger (Google), 2013-02-12 18:23:15]

LGTM but please edit the CL desc to read:

Prevent translated key events (WM_CHAR) associated with key events that focus
the WebContents from being sent to the renderer, as they are not intended to
target the renderer.

Example:

When the focus is in the omnibox, and a new URL is typed and Enter is pressed,
the Enter keypress should focus the WebContents but the WebContents should not
send the Enter char event to the current page.