Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2652863002: Fix a crash caused by missing download ID from system DownloadManager for OMA downloads (Closed)

Created:
3 years, 11 months ago by qinmin
Modified:
3 years, 11 months ago
Reviewers:
gone
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a crash caused by missing download ID from system DownloadManager for OMA downloads When chrome crashes while OMA download is in progress, chrome will clear the download infomation when it restarts. However, it is possible that the system download Id no longer exists in DownloadManager. This will cause Chrome to crash on the first start up. This CL catches the problem so we don't crash in this rare cases. BUG=684100 Review-Url: https://codereview.chromium.org/2652863002 Cr-Commit-Position: refs/heads/master@{#445544} Committed: https://chromium.googlesource.com/chromium/src/+/3482758e2164874b6d52e320e354da289b1c2c47

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
qinmin
PTAL
3 years, 11 months ago (2017-01-23 22:48:11 UTC) #2
gone
lgtm
3 years, 11 months ago (2017-01-23 22:49:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652863002/1
3 years, 11 months ago (2017-01-23 22:55:28 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 23:36:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3482758e2164874b6d52e320e354...

Powered by Google App Engine
This is Rietveld 408576698