Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1435)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java

Issue 2652863002: Fix a crash caused by missing download ID from system DownloadManager for OMA downloads (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
index d47702ee6c9a696b22dca550994f7d76c69fb468..00c85694bb33f6d553f2f19bd63ea5b9d2bacb22 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
@@ -433,8 +433,10 @@ public class DownloadManagerService extends BroadcastReceiver implements
mOMADownloadHandler.onDownloadFailed(
mDownloadInfo, downloadId, mFailureReason, mInstallNotifyURI);
removeOMADownloadFromSharedPrefs(downloadId);
- String fileName = mDownloadInfo.getFileName();
- onDownloadFailed(fileName, mFailureReason);
+ if (mDownloadInfo != null) {
+ String fileName = mDownloadInfo.getFileName();
+ onDownloadFailed(fileName, mFailureReason);
+ }
}
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698