Issue 26528002: Add SK_CROP_RECT_IS_INT to Chrome's Skia build, in order to avoid build-breakage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26528002: Add SK_CROP_RECT_IS_INT to Chrome's Skia build, in order to avoid build-breakage (Closed)

Created:
7 years, 2 months ago by Stephen White

Modified:
7 years, 2 months ago

Reviewers:
robertphillips

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Preemptively add SK_CROP_RECT_IS_INT=1 to Chrome's Skia build, in order to avoid build-breakage until Blink has switched to SkScalar-based crop rects. BUG=

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	skia/skia_library.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm but I have also incorporated these changes into today's roll: https://codereview.chromium.org/26702006/

7 years, 2 months ago (2013-10-10 12:01:50 UTC) #2

commit-bot: I haz the power

No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...

7 years, 2 months ago (2013-10-10 12:15:33 UTC) #3

Stephen White

7 years, 2 months ago (2013-10-10 14:13:57 UTC) #4

On 2013/10/10 12:01:50, robertphillips wrote:
> lgtm but I have also incorporated these changes into today's roll:
> https://codereview.chromium.org/26702006/

Fantastic! Closing...

Expand Messages | Collapse Messages