Issue 26702006: Roll Skia DEPS to r11688

Issue 26702006: Roll Skia DEPS to r11688 (Closed)

Created:
7 years, 2 months ago by robertphillips

Modified:
7 years, 2 months ago

Reviewers:
bsalomon, rmistry, reed1

CC:
chromium-reviews, skia-team_google.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Roll Skia DEPS to r11688 R=bsalomon@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227916

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -2 lines)			Patch
M	DEPS	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	skia/skia_library.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	skia/skia_library_opts.gyp	View	5 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

robertphillips

control: https://codereview.chromium.org/26680006/

7 years, 2 months ago (2013-10-09 23:06:39 UTC) #1

robertphillips

I believe this is 'good'. The discrepancies between the roll and control are: linux_chromeos_asan roll: ...

7 years, 2 months ago (2013-10-10 12:00:06 UTC) #2

I believe this is 'good'. The discrepancies between the roll and control are:

linux_chromeos_asan
   roll:    
            buildrunner_tests preamble
            content_browsertests did not complete failed 3
                SingleProcess ************************************************
                SerializeHTMLDOMWithEntitiesInText ***************************
                GetSavableResourceLinksWithPageHasInvalidLinks ***************
   control: 
            buildrunner_tests preamble
            content_browsertests failed 2
                SerializeDocumentWithDownloadedIFrame
                SubResourceForElementsInNonHTMLNamespace

mac_asan
   roll:    
            buildrunner_tests preamble
            interactive_ui_tests failed 2
                ShowURL ******************************************************
                SendThemeBackgroundChangedEvent ******************************
            telemetry_unittests failed 2
                testGetDOMStats **********************************************
                testBoundingClientRect ***************************************
            unit_tests crashed or hung
            nacl_integration
   control: 
            buildrunner_tests preamble
            interactive_ui_tests failed 1
                NoMostVisitedChangedOnTabSwitch
            telemetry_unittests failed 1
                testMultipleTabCalls
            unit_tests crashed or hung
            nacl_integration

win_gpu
   roll:    
            running steps via annotated script preamble
            content_browsertests failed 1
                MANUAL_conformance_rendering_gl_scissor_test
            webgl_conformance_tests
   control: 
            green

win_layout
   roll:    
            webkit_tests 323 fixable (0 skipped) failed 2
                appcache-swap.html
                online-whitelist.html
            buildrunner_tests preamble
            webkit_unit_tests 13 disabled failed 1
                SetBaseBackgroundColor ***************************************
   control: 
            webkit_tests 420 fixable (0 skipped) failed 69
                includes both of the roll's failures

bsalomon

On 2013/10/10 12:00:06, robertphillips wrote: > I believe this is 'good'. The discrepancies between the ...

7 years, 2 months ago (2013-10-10 13:06:02 UTC) #3

On 2013/10/10 12:00:06, robertphillips wrote:
> I believe this is 'good'. The discrepancies between the roll and control are:
> 
> linux_chromeos_asan
>    roll:    
>             buildrunner_tests preamble
>             content_browsertests did not complete failed 3
>                 SingleProcess ************************************************
>                 SerializeHTMLDOMWithEntitiesInText ***************************
>                 GetSavableResourceLinksWithPageHasInvalidLinks ***************
>    control: 
>             buildrunner_tests preamble
>             content_browsertests failed 2
>                 SerializeDocumentWithDownloadedIFrame
>                 SubResourceForElementsInNonHTMLNamespace
> 
> mac_asan
>    roll:    
>             buildrunner_tests preamble
>             interactive_ui_tests failed 2
>                 ShowURL ******************************************************
>                 SendThemeBackgroundChangedEvent ******************************
>             telemetry_unittests failed 2
>                 testGetDOMStats **********************************************
>                 testBoundingClientRect ***************************************
>             unit_tests crashed or hung
>             nacl_integration
>    control: 
>             buildrunner_tests preamble
>             interactive_ui_tests failed 1
>                 NoMostVisitedChangedOnTabSwitch
>             telemetry_unittests failed 1
>                 testMultipleTabCalls
>             unit_tests crashed or hung
>             nacl_integration
> 
> win_gpu
>    roll:    
>             running steps via annotated script preamble
>             content_browsertests failed 1
>                 MANUAL_conformance_rendering_gl_scissor_test
>             webgl_conformance_tests
>    control: 
>             green
> 
> win_layout
>    roll:    
>             webkit_tests 323 fixable (0 skipped) failed 2
>                 appcache-swap.html
>                 online-whitelist.html
>             buildrunner_tests preamble
>             webkit_unit_tests 13 disabled failed 1
>                 SetBaseBackgroundColor ***************************************
>    control: 
>             webkit_tests 420 fixable (0 skipped) failed 69
>                 includes both of the roll's failures

lgtm

robertphillips

7 years, 2 months ago (2013-10-10 13:06:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r227916 (presubmit successful).

Expand Messages | Collapse Messages