Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2652723002: Ensure DEFINE_STATIC_LOCAL can be used before wtf threading is initialized (Closed)

Created:
3 years, 11 months ago by Charlie Harrison
Modified:
3 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure DEFINE_STATIC_LOCAL can be used before wtf threading is initialized This patch just makes StaticLocalVerifier make thread id syscalls rather than using TLS lookups. BUG=681290 Review-Url: https://codereview.chromium.org/2652723002 Cr-Commit-Position: refs/heads/master@{#445479} Committed: https://chromium.googlesource.com/chromium/src/+/af533915964a542005b59457bbf27fcd20972590

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M third_party/WebKit/Source/wtf/StdLibExtras.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/Threading.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
Charlie Harrison
haraken: PTAL. I had trouble writing a test for this, because all test infrastructure initializes ...
3 years, 11 months ago (2017-01-23 16:00:46 UTC) #6
haraken
LGTM
3 years, 11 months ago (2017-01-23 16:26:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652723002/1
3 years, 11 months ago (2017-01-23 17:49:05 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/376007)
3 years, 11 months ago (2017-01-23 19:21:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652723002/1
3 years, 11 months ago (2017-01-23 19:25:00 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 20:54:10 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/af533915964a542005b59457bbf2...

Powered by Google App Engine
This is Rietveld 408576698