Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Side by Side Diff: third_party/WebKit/Source/wtf/StdLibExtras.h

Issue 2652723002: Ensure DEFINE_STATIC_LOCAL can be used before wtf threading is initialized (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/wtf/Threading.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 25 matching lines...) Expand all
36 #if DCHECK_IS_ON() 36 #if DCHECK_IS_ON()
37 #include "wtf/Noncopyable.h" 37 #include "wtf/Noncopyable.h"
38 #include "wtf/Threading.h" 38 #include "wtf/Threading.h"
39 39
40 class WTF_EXPORT StaticLocalVerifier { 40 class WTF_EXPORT StaticLocalVerifier {
41 WTF_MAKE_NONCOPYABLE(StaticLocalVerifier); 41 WTF_MAKE_NONCOPYABLE(StaticLocalVerifier);
42 42
43 public: 43 public:
44 StaticLocalVerifier() 44 StaticLocalVerifier()
45 : m_safelyInitialized(WTF::isBeforeThreadCreated()), 45 : m_safelyInitialized(WTF::isBeforeThreadCreated()),
46 m_thread(WTF::currentThread()) {} 46 m_thread(WTF::internal::currentThreadSyscall()) {}
47 47
48 bool isNotRacy() { 48 bool isNotRacy() {
49 // Make sure that this 1) is safely initialized, 2) keeps being called 49 // Make sure that this 1) is safely initialized, 2) keeps being called
50 // on the same thread, or 3) is called within 50 // on the same thread, or 3) is called within
51 // AtomicallyInitializedStatic (i.e. with a lock held). 51 // AtomicallyInitializedStatic (i.e. with a lock held).
52 return m_safelyInitialized || m_thread == WTF::currentThread() || 52 return m_safelyInitialized ||
53 m_thread == WTF::internal::currentThreadSyscall() ||
53 WTF::isAtomicallyInitializedStaticMutexLockHeld(); 54 WTF::isAtomicallyInitializedStaticMutexLockHeld();
54 } 55 }
55 56
56 private: 57 private:
57 bool m_safelyInitialized; 58 bool m_safelyInitialized;
58 ThreadIdentifier m_thread; 59 ThreadIdentifier m_thread;
59 }; 60 };
60 #endif 61 #endif
61 62
62 namespace blink { 63 namespace blink {
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
238 enum NotNullTag { NotNull }; 239 enum NotNullTag { NotNull };
239 inline void* operator new(size_t, NotNullTag, void* location) { 240 inline void* operator new(size_t, NotNullTag, void* location) {
240 DCHECK(location); 241 DCHECK(location);
241 return location; 242 return location;
242 } 243 }
243 244
244 using WTF::bitwiseCast; 245 using WTF::bitwiseCast;
245 using WTF::safeCast; 246 using WTF::safeCast;
246 247
247 #endif // WTF_StdLibExtras_h 248 #endif // WTF_StdLibExtras_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/wtf/Threading.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698