Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2652673002: MIPS: Workaround for bug in MIPS Android compiler (Closed)

Created:
3 years, 11 months ago by predrag.rudic
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Workaround for bug in MIPS Android compiler This patch fixes an issue with compilation with MIPS Android compiler NDK r12b, gcc version mipsel-linux-android-g++ (GCC) 4.9.x 20150123 (prerelease). The problem has been reported to the compiler team, the workaround should be reverted when the issue with compiler is resolved. BUG= Review-Url: https://codereview.chromium.org/2652673002 Cr-Commit-Position: refs/heads/master@{#42732} Committed: https://chromium.googlesource.com/v8/v8/+/dbbd2da128a2012619cf448a2167312f51081ca0

Patch Set 1 #

Patch Set 2 : Change to test so it won't fail on our board any more. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/heap/store-buffer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
ivica.bogosavljevic
This is the workaround for compilation failure on MIPS android, as discusses per e-mail
3 years, 11 months ago (2017-01-23 13:59:35 UTC) #2
Michael Lippautz
On 2017/01/23 13:59:35, ivica.bogosavljevic wrote: > This is the workaround for compilation failure on MIPS ...
3 years, 11 months ago (2017-01-25 14:11:48 UTC) #3
Michael Lippautz
On 2017/01/23 13:59:35, ivica.bogosavljevic wrote: > This is the workaround for compilation failure on MIPS ...
3 years, 11 months ago (2017-01-25 14:11:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652673002/1
3 years, 10 months ago (2017-01-27 11:15:39 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 11:17:43 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/dbbd2da128a2012619cf448a2167312f510...

Powered by Google App Engine
This is Rietveld 408576698