Issue 2652623003: Fix flickering in new tab title after r444582.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2652623003: Fix flickering in new tab title after r444582. (Closed)

Created:
3 years, 11 months ago by jam

Modified:
3 years, 11 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

Fix flickering in new tab title after r444582. DidStartNavigation is called too late to prevent flickering with PlzNavigate disabled. So bring back overriding of DidStartNavigationToPendingEntry for the non-PlzNavigate case. BUG=682774 Review-Url: https://codereview.chromium.org/2644963004 Cr-Commit-Position: refs/heads/master@{#445055} (cherry picked from commit b1c7a2ae38ea453f101480ab91ee98e6acebf56f) Review-Url: https://codereview.chromium.org/2652623003 . Cr-Commit-Position: refs/branch-heads/2987@{#30} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/a397c029afd7f52bcfd153bca4082872ef7332f2

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -0 lines)			Patch
	M	chrome/browser/ui/search/search_tab_helper.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/search/search_tab_helper.cc	View		2 chunks	+28 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

jam

3 years, 11 months ago (2017-01-23 18:47:36 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a397c029afd7f52bcfd153bca4082872ef7332f2.