Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2644963004: Fix flickering in new tab title after r444582. (Closed)

Created:
3 years, 11 months ago by jam
Modified:
3 years, 11 months ago
Reviewers:
Marc Treib
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flickering in new tab title after r444582. DidStartNavigation is called too late to prevent flickering with PlzNavigate disabled. So bring back overriding of DidStartNavigationToPendingEntry for the non-PlzNavigate case. BUG=682774 Review-Url: https://codereview.chromium.org/2644963004 Cr-Commit-Position: refs/heads/master@{#445055} Committed: https://chromium.googlesource.com/chromium/src/+/b1c7a2ae38ea453f101480ab91ee98e6acebf56f

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M chrome/browser/ui/search/search_tab_helper.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper.cc View 2 chunks +28 lines, -0 lines 6 comments Download

Messages

Total messages: 15 (8 generated)
jam
3 years, 11 months ago (2017-01-20 06:45:38 UTC) #4
Marc Treib
LGTM with nits https://codereview.chromium.org/2644963004/diff/1/chrome/browser/ui/search/search_tab_helper.cc File chrome/browser/ui/search/search_tab_helper.cc (right): https://codereview.chromium.org/2644963004/diff/1/chrome/browser/ui/search/search_tab_helper.cc#newcode228 chrome/browser/ui/search/search_tab_helper.cc:228: // case. Is there a bug ...
3 years, 11 months ago (2017-01-20 09:26:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644963004/1
3 years, 11 months ago (2017-01-20 15:09:21 UTC) #9
jam
https://codereview.chromium.org/2644963004/diff/1/chrome/browser/ui/search/search_tab_helper.cc File chrome/browser/ui/search/search_tab_helper.cc (right): https://codereview.chromium.org/2644963004/diff/1/chrome/browser/ui/search/search_tab_helper.cc#newcode228 chrome/browser/ui/search/search_tab_helper.cc:228: // case. On 2017/01/20 09:26:47, Marc Treib wrote: > ...
3 years, 11 months ago (2017-01-20 15:11:35 UTC) #10
Marc Treib
On 2017/01/20 15:09:21, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 11 months ago (2017-01-20 15:12:01 UTC) #11
Marc Treib
On 2017/01/20 15:12:01, Marc Treib wrote: > On 2017/01/20 15:09:21, commit-bot: I haz the power ...
3 years, 11 months ago (2017-01-20 15:13:12 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 15:13:19 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b1c7a2ae38ea453f101480ab91ee...

Powered by Google App Engine
This is Rietveld 408576698