Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 2652263003: Remove build_overrides/v8.gni. (Closed)

Created:
3 years, 11 months ago by brettw
Modified:
3 years, 11 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, Paweł Hajdan Jr.
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove build_overrides/v8.gni. Chrome now uses the default_args system for specifying its own definitions of these variables so the separate file in build_overrides is no longer necessary. BUG=684096 Review-Url: https://codereview.chromium.org/2652263003 Cr-Commit-Position: refs/heads/master@{#42712} Committed: https://chromium.googlesource.com/v8/v8/+/9d9711a8eb6146267f89f889c21d30a6956bb8a4

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : Remove file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -48 lines) Patch
M BUILD.gn View 2 chunks +7 lines, -29 lines 0 comments Download
D build_overrides/v8.gni View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M gni/v8.gni View 2 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 25 (18 generated)
brettw
I will land this after https://codereview.chromium.org/2648233006/ goes in, which is required to keep Chrome unchanged.
3 years, 11 months ago (2017-01-25 21:28:55 UTC) #4
brettw
The Chrome change has gone in so this should be ready.
3 years, 11 months ago (2017-01-25 22:49:11 UTC) #11
brettw
I *think* the GN error is because Chromium needs to be rolled into V8. Is ...
3 years, 11 months ago (2017-01-26 00:10:40 UTC) #14
Michael Achenbach
On 2017/01/26 00:10:40, brettw (ping after 24h) wrote: > I *think* the GN error is ...
3 years, 11 months ago (2017-01-26 07:35:47 UTC) #17
Michael Achenbach
lgtm
3 years, 11 months ago (2017-01-26 07:47:01 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652263003/60001
3 years, 11 months ago (2017-01-26 20:17:03 UTC) #22
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 20:19:05 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/9d9711a8eb6146267f89f889c21d30a6956...

Powered by Google App Engine
This is Rietveld 408576698