Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1271)

Unified Diff: gni/v8.gni

Issue 2652263003: Remove build_overrides/v8.gni. (Closed)
Patch Set: Remove file Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build_overrides/v8.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gni/v8.gni
diff --git a/gni/v8.gni b/gni/v8.gni
index 1f26674108a2e86dfa7e7824049c99f35ac6ac5f..c1a3b7cca9286fe6b90793fa21d9da6dc643c7c9 100644
--- a/gni/v8.gni
+++ b/gni/v8.gni
@@ -4,7 +4,6 @@
import("//build/config/sanitizers/sanitizers.gni")
import("//build/config/v8_target_cpu.gni")
-import("//build_overrides/v8.gni")
declare_args() {
# Includes files needed for correctness fuzzing.
@@ -35,16 +34,8 @@ declare_args() {
# add a dependency on the ICU library.
v8_enable_i18n_support = true
- # TODO(brettw) http://crbug.com/684096 Remove the define condition and the
- # v8_enable_inspector_override variable when the build_override conversion is
- # complete. This value should just default to true.
- if (defined(v8_enable_inspector_override)) {
- # Enable inspector. See include/v8-inspector.h.
- v8_enable_inspector = v8_enable_inspector_override
- } else {
- # Enable inspector. See include/v8-inspector.h.
- v8_enable_inspector = true
- }
+ # Enable inspector. See include/v8-inspector.h.
+ v8_enable_inspector = true
# Use static libraries instead of source_sets.
v8_static_library = false
« no previous file with comments | « build_overrides/v8.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698