Disable swarming for tests where it's disabled on builder level (FYI masters)

Disable swarming for tests where it's disabled on builder level (FYI masters)

See https://codereview.chromium.org/2649923009/ for previous CL
for production builders.

BUG=684527, 684067
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
R=bajones@chromium.org, kbr@chromium.org, maruel@chromium.org

Review-Url: https://codereview.chromium.org/2652223002 .
Cr-Commit-Position: refs/heads/master@{#446277}
Committed: https://chromium.googlesource.com/chromium/src/+/c4902f0922c2f1553486109786427de7a284b4cb

[Paweł Hajdan Jr., 2017-01-25 13:14:59]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 13:15:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Paweł Hajdan Jr., 2017-01-25 13:15:15]

phajdan.jr@chromium.org changed reviewers:
+ maruel@chromium.org

[commit-bot: I haz the power, 2017-01-25 14:18:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 14:18:30]

Dry run: This issue passed the CQ dry run.

[M-A Ruel, 2017-01-25 15:04:35]

maruel@chromium.org changed reviewers:
+ kbr@chromium.org

[M-A Ruel, 2017-01-25 15:04:36]

You can't modify chromium.gpu.fyi.json, it is generated by
content/test/gpu/generate_buildbot_json.py.

[Paweł Hajdan Jr., 2017-01-25 17:24:57]

Description was changed from

==========
Disable swarming for tests where it's disabled on builder level (FYI masters)

See https://codereview.chromium.org/2649923009/ for previous CL
for production builders.

BUG=684527, 684067
==========

to

==========
Disable swarming for tests where it's disabled on builder level (FYI masters)

See https://codereview.chromium.org/2649923009/ for previous CL
for production builders.

BUG=684527, 684067
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[Paweł Hajdan Jr., 2017-01-25 17:25:32]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 17:25:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Paweł Hajdan Jr., 2017-01-25 17:41:59]

Good point. PTAL.

[commit-bot: I haz the power, 2017-01-25 19:15:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 19:16:00]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[M-A Ruel, 2017-01-25 19:35:29]

lgtm but let's wait for one of GPU folks to agree too. This doesn't actually
change anything functionally, as the flag was ineffective but it's up to them to
update the config accordingly.

[Paweł Hajdan Jr., 2017-01-25 19:56:25]

phajdan.jr@chromium.org changed reviewers:
+ bajones@chromium.org, zmo@chromium.ort

[Paweł Hajdan Jr., 2017-01-25 19:56:26]

+bajones,zmo

[Dirk Pranke, 2017-01-25 20:22:06]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org, iannucci@chromium.org

[Dirk Pranke, 2017-01-25 20:22:07]

The problem ended up being that the JSON files had swarming enabled for
individual tests, but the bots didn't have swarming enabled build-side, and so
nothing was actually being swarmed. And then, when you turned on swarming
build-side, we saw failures where the swarmed tests didn't actually work right?

And to get around this, this CL and the other one is making it so that if
swarming is disabled build-side (currently) the tests will disable swarming
src-side as well, right? Then you can land the build-side change enabling
swarming everywhere, and we can come back and enable swarming src-side and fix
bugs?

(Just trying to make sure I have everything straight).

https://codereview.chromium.org/2652223002/diff/20001/content/test/gpu/genera...
File content/test/gpu/generate_buildbot_json.py (right):

https://codereview.chromium.org/2652223002/diff/20001/content/test/gpu/genera...
content/test/gpu/generate_buildbot_json.py:1643: # swarmed, they will come in
handy.
this comment and the comment down on lines 1754-1755 are wrong now, right? Turns
out it did hurt :).

[bajones, 2017-01-25 22:16:50]

Owners RS LGTM. Doesn't immediately worry me, but I can't claim I know all of
the implications either.

[Ken Russell (switch to Gerrit), 2017-01-25 22:28:09]

lgtm

https://codereview.chromium.org/2652223002/diff/20001/content/test/gpu/genera...
File content/test/gpu/generate_buildbot_json.py (right):

https://codereview.chromium.org/2652223002/diff/20001/content/test/gpu/genera...
content/test/gpu/generate_buildbot_json.py:1755: # supports swarming. It doesn't
hurt.
Agree with Dirk's comment above. Please update this comment indicating that this
is the switch which determines how these tests are run. I'm not 100% sure about
the direction of this work but it sounds like the machine-level Swarming switch
is being removed.

[Dirk Pranke, 2017-01-25 23:59:05]

On 2017/01/25 22:28:09, Ken Russell OOO-till-Jan-27 wrote:
> I'm not 100% sure about
> the direction of this work but it sounds like the machine-level Swarming
switch
> is being removed.

Correct.

[Paweł Hajdan Jr., 2017-01-26 08:18:59]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 08:19:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Paweł Hajdan Jr., 2017-01-26 08:19:24]

Okay, removed the comments.

[Paweł Hajdan Jr., 2017-01-26 08:32:44]

Description was changed from

==========
Disable swarming for tests where it's disabled on builder level (FYI masters)

See https://codereview.chromium.org/2649923009/ for previous CL
for production builders.

BUG=684527, 684067
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Disable swarming for tests where it's disabled on builder level (FYI masters)

See https://codereview.chromium.org/2649923009/ for previous CL
for production builders.

BUG=684527, 684067
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
R=bajones@chromium.org, kbr@chromium.org, maruel@chromium.org

Review-Url: https://codereview.chromium.org/2652223002 .
Cr-Commit-Position: refs/heads/master@{#446277}
Committed:
https://chromium.googlesource.com/chromium/src/+/c4902f0922c2f155348610978642...
==========

[Paweł Hajdan Jr., 2017-01-26 08:32:46]

Committed patchset #3 (id:40001) manually as
c4902f0922c2f1553486109786427de7a284b4cb.

[Michael Achenbach, 2017-01-26 08:35:22]

How about client.v8.fyi?

[Paweł Hajdan Jr., 2017-01-26 15:30:37]

Description was changed from

==========
Disable swarming for tests where it's disabled on builder level (FYI masters)

See https://codereview.chromium.org/2649923009/ for previous CL
for production builders.

BUG=684527, 684067
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
R=bajones@chromium.org, kbr@chromium.org, maruel@chromium.org

Review-Url: https://codereview.chromium.org/2652223002 .
Cr-Commit-Position: refs/heads/master@{#446277}
Committed:
https://chromium.googlesource.com/chromium/src/+/c4902f0922c2f155348610978642...
==========

to

==========
Disable swarming for tests where it's disabled on builder level (FYI masters)

See https://codereview.chromium.org/2649923009/ for previous CL
for production builders.

BUG=684527, 684067
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
R=bajones@chromium.org, kbr@chromium.org, maruel@chromium.org

Review-Url: https://codereview.chromium.org/2652223002 .
Cr-Commit-Position: refs/heads/master@{#446277}
Committed:
https://chromium.googlesource.com/chromium/src/+/c4902f0922c2f155348610978642...
==========

[Paweł Hajdan Jr., 2017-01-26 15:30:56]

On 2017/01/26 08:35:22, Michael Achenbach wrote:
> How about client.v8.fyi?

For reference, looks like no change was needed.