Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: content/test/gpu/generate_buildbot_json.py

Issue 2652223002: Disable swarming for tests where it's disabled on builder level (FYI masters) (Closed)
Patch Set: review Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | testing/buildbot/chromium.fyi.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/gpu/generate_buildbot_json.py
diff --git a/content/test/gpu/generate_buildbot_json.py b/content/test/gpu/generate_buildbot_json.py
index 8aed8ca1fcc64f8104919a2a236f6da36c70a02b..76ae1efe21a77090849fa7afe55e34876c3b908e 100755
--- a/content/test/gpu/generate_buildbot_json.py
+++ b/content/test/gpu/generate_buildbot_json.py
@@ -1639,12 +1639,10 @@ def generate_gtest(tester_name, tester_config, test, test_config,
result = copy.deepcopy(NON_SWARMED_GTESTS[test])
result['name'] = test
else:
- # Put the swarming dimensions in anyway. If the tester is later
- # swarmed, they will come in handy.
if not 'swarming' in result:
result['swarming'] = {}
result['swarming'].update({
- 'can_use_on_swarming_builders': True,
+ 'can_use_on_swarming_builders': tester_config['swarming'],
'dimension_sets': tester_config['swarming_dimensions']
})
if is_android(tester_config):
@@ -1751,9 +1749,7 @@ def generate_isolated_test(tester_name, tester_config, test, test_config,
step_name = '%s_tests' % step_name
# Prepend GPU-specific flags.
swarming = {
- # Always say this is true regardless of whether the tester
- # supports swarming. It doesn't hurt.
- 'can_use_on_swarming_builders': True,
+ 'can_use_on_swarming_builders': tester_config['swarming'],
'dimension_sets': tester_config['swarming_dimensions']
}
if 'swarming' in test_config:
« no previous file with comments | « no previous file | testing/buildbot/chromium.fyi.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698