Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 2652083002: Explicitly set v8_enable_gdbjit_default for v8 overrides. (Closed)

Created:
3 years, 11 months ago by brettw
Modified:
3 years, 11 months ago
Reviewers:
Michael Achenbach
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly set v8_enable_gdbjit_default for v8 overrides. This is a fix for https://codereview.chromium.org/2648383003 where v8_enable_gdbjit should actually be v8_enable_gdbjit_default. This was pointed out in the review for https://codereview.chromium.org/2654663003/ BUG=684096 R=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2652083002 Cr-Commit-Position: refs/heads/master@{#445835} Committed: https://chromium.googlesource.com/chromium/src/+/cc77cea884ab97d4eab6abc8c7f809377941a382

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build_overrides/v8.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
brettw
3 years, 11 months ago (2017-01-24 20:34:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652083002/1
3 years, 11 months ago (2017-01-24 20:35:25 UTC) #3
Michael Achenbach
lgtm
3 years, 11 months ago (2017-01-24 20:38:56 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/199264)
3 years, 11 months ago (2017-01-24 21:04:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652083002/1
3 years, 11 months ago (2017-01-24 21:16:03 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 22:17:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cc77cea884ab97d4eab6abc8c7f8...

Powered by Google App Engine
This is Rietveld 408576698