Explicitly set some V8 build flags

Explicitly set some V8 build flags

These are currently implicitly set if undefined in v8/BUILD.gn. As part of
moving to the new default_args system, this will need to be explicit to roll
the new V8 in.

This should be a build no-op.

BUG=684096
Review-Url: https://codereview.chromium.org/2648383003
Cr-Commit-Position: refs/heads/master@{#445757}
Committed: https://chromium.googlesource.com/chromium/src/+/8a08c1ded65a1e9271afc3872f88180edae0c5ce

[brettw, 2017-01-24 00:34:49]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2017-01-24 00:35:03]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 00:35:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2017-01-24 00:37:04]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2017-01-24 00:38:31]

Description was changed from

==========
Explicitly turn off V8 deprecation warnings.

This is currently off by defaul in v8/BUILD.gn if it is undefined. As part of
moving to the new default_args system, this will need to be explicit to roll
the new V8 in.

BUG=684096
==========

to

==========
Explicitly set some V8 build flags

These are currently implicitly set if undefined in v8/BUILD.gn. As part of
moving to the new default_args system, this will need to be explicit to roll
the new V8 in.

BUG=684096
==========

[brettw, 2017-01-24 00:38:45]

Description was changed from

==========
Explicitly set some V8 build flags

These are currently implicitly set if undefined in v8/BUILD.gn. As part of
moving to the new default_args system, this will need to be explicit to roll
the new V8 in.

BUG=684096
==========

to

==========
Explicitly set some V8 build flags

These are currently implicitly set if undefined in v8/BUILD.gn. As part of
moving to the new default_args system, this will need to be explicit to roll
the new V8 in.

This should be a build no-op.

BUG=684096
==========

[brettw, 2017-01-24 00:38:48]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 00:39:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2017-01-24 00:48:52]

Fix

[brettw, 2017-01-24 00:48:53]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2017-01-24 00:49:17]

Patchset #3 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-01-24 00:49:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2017-01-24 02:18:48]

lgtm.

[commit-bot: I haz the power, 2017-01-24 02:50:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 02:50:59]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2017-01-24 08:17:48]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2017-01-24 08:17:49]

lgtm

[brettw, 2017-01-24 18:00:05]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2017-01-24 18:00:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2017-01-24 18:01:41]

On 2017/01/24 08:17:49, Michael Achenbach wrote:
> lgtm

Thanks Michael, in case you missed it I need your review on this other patch
too: https://codereview.chromium.org/2654663003/

[commit-bot: I haz the power, 2017-01-24 18:04:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485280805752900,
"parent_rev": "7cf0a2ae60d21e220291cab0cf3f6579bf933f25", "commit_rev":
"8a08c1ded65a1e9271afc3872f88180edae0c5ce"}

[commit-bot: I haz the power, 2017-01-24 18:05:20]

Description was changed from

==========
Explicitly set some V8 build flags

These are currently implicitly set if undefined in v8/BUILD.gn. As part of
moving to the new default_args system, this will need to be explicit to roll
the new V8 in.

This should be a build no-op.

BUG=684096
==========

to

==========
Explicitly set some V8 build flags

These are currently implicitly set if undefined in v8/BUILD.gn. As part of
moving to the new default_args system, this will need to be explicit to roll
the new V8 in.

This should be a build no-op.

BUG=684096

Review-Url: https://codereview.chromium.org/2648383003
Cr-Commit-Position: refs/heads/master@{#445757}
Committed:
https://chromium.googlesource.com/chromium/src/+/8a08c1ded65a1e9271afc3872f88...
==========

[commit-bot: I haz the power, 2017-01-24 18:05:21]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8a08c1ded65a1e9271afc3872f88...