Issue 2652043002: Revert "Revert "Put the close button of a notification into focus chain.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2652043002: Revert "Revert "Put the close button of a notification into focus chain."" (Closed)

Created:
3 years, 11 months ago by xiyuan

Modified:
3 years, 11 months ago

Reviewers:
yoshiki

CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

Revert "Revert "Put the close button of a notification into focus chain."" This reverts commit 921ef9abaa6c04e230104723f2d32906a8f136e1. Revert the temp revert to prepare for merge the fix https://codereview.chromium.org/2646143002. BUG=682868, 661105 TBR=yoshiki@chromium.org Review-Url: https://codereview.chromium.org/2652043002 . Cr-Commit-Position: refs/branch-heads/2987@{#60} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/190148059453a70e383e8856794ad9d43dafce3f

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -28 lines)			Patch
	M	ui/arc/notification/arc_custom_notification_view.h	View		3 chunks	+3 lines, -0 lines	0 comments	Download
	M	ui/arc/notification/arc_custom_notification_view.cc	View		5 chunks	+58 lines, -28 lines	0 comments	Download

Total messages: 2 (1 generated)

xiyuan

3 years, 11 months ago (2017-01-24 18:10:42 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
190148059453a70e383e8856794ad9d43dafce3f (presubmit successful).