Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2646143002:
arc: Fix CreateFloatingCloseButton crash (Closed)
|
Created:
3 years, 11 months ago by xiyuan Modified:
3 years, 11 months ago Reviewers:
yoshiki CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionarc: Fix CreateFloatingCloseButton crash
Move UpdatePinnedState into AttachSurface since floating close button
participates in the focus chain of the hosting widget now. To create it,
both |surface_| and the hosting widget needs to be present.
BUG=682868
Review-Url: https://codereview.chromium.org/2646143002
Cr-Commit-Position: refs/heads/master@{#445754}
Committed: https://chromium.googlesource.com/chromium/src/+/57d39edccd4352d933347b9742010740cef62ce5
Patch Set 1 #
Messages
Total messages: 20 (10 generated)
The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run
xiyuan@chromium.org changed reviewers: + yoshiki@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ping?
On 2017/01/23 17:02:07, xiyuan wrote: > ping? yoshiki is ooo this week.
lgtm
On 2017/01/24 04:09:11, Junichi Uekawa wrote: > On 2017/01/23 17:02:07, xiyuan wrote: > > ping? > > yoshiki is ooo this week. Xiyuan, please add yhanada@ for fast reviewing since I may delay. Uekawa-san, thank you for notifying!
On 2017/01/24 10:14:19, yoshiki wrote: > On 2017/01/24 04:09:11, Junichi Uekawa wrote: > > On 2017/01/23 17:02:07, xiyuan wrote: > > > ping? > > > > yoshiki is ooo this week. > > Xiyuan, please add yhanada@ for fast reviewing since I may delay. > > Uekawa-san, thank you for notifying! Thanks for doing the review while ooo. :)
The CQ bit was checked by xiyuan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by xiyuan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485279008691070, "parent_rev":
"6b46a16a65bde16639a7e68ea1d1978761121074", "commit_rev":
"57d39edccd4352d933347b9742010740cef62ce5"}
Message was sent while issue was closed.
Description was changed from ========== arc: Fix CreateFloatingCloseButton crash Move UpdatePinnedState into AttachSurface since floating close button participates in the focus chain of the hosting widget now. To create it, both |surface_| and the hosting widget needs to be present. BUG=682868 ========== to ========== arc: Fix CreateFloatingCloseButton crash Move UpdatePinnedState into AttachSurface since floating close button participates in the focus chain of the hosting widget now. To create it, both |surface_| and the hosting widget needs to be present. BUG=682868 Review-Url: https://codereview.chromium.org/2646143002 Cr-Commit-Position: refs/heads/master@{#445754} Committed: https://chromium.googlesource.com/chromium/src/+/57d39edccd4352d933347b974201... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/57d39edccd4352d933347b974201... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
