Wires up ShouldDescendIntoChildForEventHandling() for DesktopNativeWidgetAura

Wires up ShouldDescendIntoChildForEventHandling() for DesktopNativeWidgetAura

I promoted the implementation from NativeWidgetAura to Widget and both
call it. As Widget is used by mac I had to pass in gfx::NativeView and
the layers. I could have ifdef'd the function, but hopefully mac will
eventually be aura based and will want to use the Widget
implementation too.

BUG=640365
TEST=none
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2651753003
Cr-Commit-Position: refs/heads/master@{#446085}
Committed: https://chromium.googlesource.com/chromium/src/+/0ce28d085257f28db8594dda526f33dc20597fd0

[sky, 2017-01-24 03:34:55]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 03:35:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 04:41:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 04:41:29]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[sky, 2017-01-24 17:45:17]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 17:45:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-01-24 18:15:37]

lgtm

[sky, 2017-01-24 18:46:17]

The CQ bit was unchecked by sky@chromium.org

[sky, 2017-01-24 18:46:21]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-01-24 18:46:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 19:19:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 19:19:23]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[sky, 2017-01-24 20:21:12]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-01-24 20:21:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 21:20:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 21:20:12]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[sky, 2017-01-24 21:37:04]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-01-24 21:37:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 22:54:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 22:54:28]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[sky, 2017-01-25 17:28:56]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 17:29:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-01-25 17:42:49]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 17:43:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-01-25 18:43:59]

The telemetry tests uncovered a real bug in this code. The code was not
considering the visible bounds of the View, only the bounds of the layer. They
may differ. For event targetting we consider the visible bounds, so
ShouldDescendIntoChildForEventHandling() also needs to consider the visible
bounds. I added a test. Take another look?

[Elliot Glaysher, 2017-01-25 18:47:51]

lgtm

[commit-bot: I haz the power, 2017-01-25 18:54:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 18:54:27]

Dry run: This issue passed the CQ dry run.

[sky, 2017-01-25 19:23:12]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-01-25 19:24:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 19:31:26]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485372192565830,
"parent_rev": "035c71f775bd40d955d7c5244bc88f33b07e63b3", "commit_rev":
"0ce28d085257f28db8594dda526f33dc20597fd0"}

[commit-bot: I haz the power, 2017-01-25 19:34:39]

Description was changed from

==========
Wires up ShouldDescendIntoChildForEventHandling() for DesktopNativeWidgetAura

I promoted the implementation from NativeWidgetAura to Widget and both
call it. As Widget is used by mac I had to pass in gfx::NativeView and
the layers. I could have ifdef'd the function, but hopefully mac will
eventually be aura based and will want to use the Widget
implementation too.

BUG=640365
TEST=none
R=erg@chromium.org
==========

to

==========
Wires up ShouldDescendIntoChildForEventHandling() for DesktopNativeWidgetAura

I promoted the implementation from NativeWidgetAura to Widget and both
call it. As Widget is used by mac I had to pass in gfx::NativeView and
the layers. I could have ifdef'd the function, but hopefully mac will
eventually be aura based and will want to use the Widget
implementation too.

BUG=640365
TEST=none
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2651753003
Cr-Commit-Position: refs/heads/master@{#446085}
Committed:
https://chromium.googlesource.com/chromium/src/+/0ce28d085257f28db8594dda526f...
==========

[commit-bot: I haz the power, 2017-01-25 19:34:40]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0ce28d085257f28db8594dda526f...