Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2651653002: Use proper descriptors array when committing state to JSON object. (Closed)

Created:
3 years, 11 months ago by Igor Sheludko
Modified:
3 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use proper descriptors array when committing state to JSON object. This CL fixes an issue introduced in https://codereview.chromium.org/2645083003. BUG=chromium:683818 Review-Url: https://codereview.chromium.org/2651653002 Cr-Commit-Position: refs/heads/master@{#42602} Committed: https://chromium.googlesource.com/v8/v8/+/87d7bb40d68a09a5197192358fb300645f9e3202

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/json-parser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Igor Sheludko
PTAL
3 years, 11 months ago (2017-01-23 11:50:51 UTC) #4
Jakob Kummerow
lgtm
3 years, 11 months ago (2017-01-23 11:52:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651653002/1
3 years, 11 months ago (2017-01-23 11:57:55 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 12:21:13 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/87d7bb40d68a09a5197192358fb300645f9...

Powered by Google App Engine
This is Rietveld 408576698