Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 2645083003: Remove one of the JSObject::WriteToField() methods in favor of another. (Closed)

Created:
3 years, 11 months ago by Igor Sheludko
Modified:
3 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove one of the JSObject::WriteToField() methods in favor of another. BUG= Review-Url: https://codereview.chromium.org/2645083003 Cr-Commit-Position: refs/heads/master@{#42571} Committed: https://chromium.googlesource.com/v8/v8/+/14bf73576c681e4c8b1a03125a3c1837ce557c92

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M src/json-parser.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
Igor Sheludko
PTAL
3 years, 11 months ago (2017-01-20 17:22:07 UTC) #4
Jakob Kummerow
lgtm
3 years, 11 months ago (2017-01-20 17:32:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645083003/20001
3 years, 11 months ago (2017-01-20 17:36:32 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 17:56:35 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/14bf73576c681e4c8b1a03125a3c1837ce5...

Powered by Google App Engine
This is Rietveld 408576698