Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2651563003: Add @override annotation on listeners. (Closed)

Created:
3 years, 11 months ago by ahe
Modified:
3 years, 11 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/fasta
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Also add @override to member_listener.dart. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -0 lines) Patch
M pkg/compiler/lib/src/parser/element_listener.dart View 31 chunks +53 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/parser/member_listener.dart View 1 5 chunks +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 52 chunks +98 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
ahe
3 years, 11 months ago (2017-01-23 12:27:20 UTC) #2
ahe
Added member_listener.dart as well.
3 years, 11 months ago (2017-01-23 12:35:21 UTC) #3
Johnni Winther
lgtm
3 years, 11 months ago (2017-01-23 12:41:00 UTC) #4
ahe
3 years, 11 months ago (2017-01-23 14:00:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ef165828418241cd795c15ac046860483be6faa4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698