Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 2649923002: Update listener error handling. (Closed)

Created:
3 years, 11 months ago by ahe
Modified:
3 years, 11 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/fasta
Project:
Fasta
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -96 lines) Patch
M pkg/compiler/lib/src/parser/element_listener.dart View 13 chunks +129 lines, -30 lines 0 comments Download
M pkg/compiler/lib/src/parser/member_listener.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 4 chunks +7 lines, -4 lines 0 comments Download
M pkg/dart_parser/lib/src/error_kind.dart View 1 chunk +22 lines, -22 lines 0 comments Download
M pkg/dart_parser/lib/src/listener.dart View 6 chunks +23 lines, -13 lines 0 comments Download
M pkg/dart_parser/lib/src/parser.dart View 15 chunks +23 lines, -23 lines 0 comments Download
M pkg/fasta/lib/src/kernel/body_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/fasta/lib/src/source/diet_parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/fasta/lib/src/source/stack_listener.dart View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (2 generated)
ahe
3 years, 11 months ago (2017-01-23 13:30:46 UTC) #2
Johnni Winther
lgtm
3 years, 11 months ago (2017-01-23 13:45:06 UTC) #3
ahe
3 years, 11 months ago (2017-01-23 14:01:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e4c33e164fa332e4b640a881f1740bc038039e11 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698