Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Unified Diff: pkg/compiler/lib/src/parser/member_listener.dart

Issue 2651563003: Add @override annotation on listeners. (Closed)
Patch Set: Also add @override to member_listener.dart. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/parser/element_listener.dart ('k') | pkg/compiler/lib/src/parser/node_listener.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/parser/member_listener.dart
diff --git a/pkg/compiler/lib/src/parser/member_listener.dart b/pkg/compiler/lib/src/parser/member_listener.dart
index cb25808e36426cc1f64355af749a3227ecd8c9d7..fbf25fb19fdc34f90f0c720bd25f4291d891cf5a 100644
--- a/pkg/compiler/lib/src/parser/member_listener.dart
+++ b/pkg/compiler/lib/src/parser/member_listener.dart
@@ -67,6 +67,7 @@ class MemberListener extends NodeListener {
}
}
+ @override
void endMethod(Token getOrSet, Token beginToken, Token endToken) {
super.endMethod(getOrSet, beginToken, endToken);
FunctionExpression method = popNode();
@@ -88,6 +89,7 @@ class MemberListener extends NodeListener {
addMember(memberElement);
}
+ @override
void endFactoryMethod(Token beginToken, Token endToken) {
super.endFactoryMethod(beginToken, endToken);
FunctionExpression method = popNode();
@@ -112,6 +114,7 @@ class MemberListener extends NodeListener {
addMember(memberElement);
}
+ @override
void endFields(int count, Token beginToken, Token endToken) {
bool hasParseError = memberErrors.head;
super.endFields(count, beginToken, endToken);
@@ -127,12 +130,14 @@ class MemberListener extends NodeListener {
enclosingClass, buildFieldElement, beginToken, endToken, hasParseError);
}
+ @override
void endInitializer(Token assignmentOperator) {
pushNode(null); // Super expects an expression, but
// ClassElementParser just skips expressions.
super.endInitializer(assignmentOperator);
}
+ @override
void endInitializers(int count, Token beginToken, Token endToken) {
pushNode(null);
}
@@ -146,6 +151,7 @@ class MemberListener extends NodeListener {
enclosingClass.addMember(memberElement, reporter);
}
+ @override
void endMetadata(Token beginToken, Token periodBeforeName, Token endToken) {
super.endMetadata(beginToken, periodBeforeName, endToken);
pushMetadata(new PartialMetadataAnnotation(beginToken, endToken));
« no previous file with comments | « pkg/compiler/lib/src/parser/element_listener.dart ('k') | pkg/compiler/lib/src/parser/node_listener.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698