Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2651543007: Use explicit WebString conversions in remaining chrome/renderer files (Closed)

Created:
3 years, 11 months ago by kinuko
Modified:
3 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews, extensions-reviews_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, chromium-apps-reviews_chromium.org, Jered
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use explicit WebString conversions in remaining chrome/renderer files As we're deprecating implicit conversions for WebString <-> string16 replace them with explicit methods. (See crbug.com/667131 for more details) BUG=667131 Review-Url: https://codereview.chromium.org/2651543007 Cr-Commit-Position: refs/heads/master@{#446022} Committed: https://chromium.googlesource.com/chromium/src/+/6e262965967f5cd06e86045a51bae65c6d818bd4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -29 lines) Patch
M chrome/renderer/chrome_content_renderer_client.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/renderer/chrome_render_frame_observer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/chrome_render_thread_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/content_settings_observer.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/extensions/page_capture_custom_bindings.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/searchbox/searchbox_extension.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/renderer/web_apps.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/renderer/worker_content_settings_client_proxy.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
kinuko
Nico, can you review this? Mostly mechanical changes only.
3 years, 11 months ago (2017-01-25 13:37:30 UTC) #3
Nico
lgtm
3 years, 11 months ago (2017-01-25 14:32:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651543007/1
3 years, 11 months ago (2017-01-25 14:32:24 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 15:23:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6e262965967f5cd06e86045a51ba...

Powered by Google App Engine
This is Rietveld 408576698