chrome/renderer/extensions/page_capture_custom_bindings.cc - Issue 2651543007: Use explicit WebString conversions in remaining chrome/renderer files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/page_capture_custom_bindings.cc

Issue 2651543007: Use explicit WebString conversions in remaining chrome/renderer files (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/page_capture_custom_bindings.cc

diff --git a/chrome/renderer/extensions/page_capture_custom_bindings.cc b/chrome/renderer/extensions/page_capture_custom_bindings.cc

index ec19aa368ef8e3dfbe2ce1a7fa54dd5b1c0931ab..41d48e0bef2af67a86c4cb97948795810c628814 100644

--- a/chrome/renderer/extensions/page_capture_custom_bindings.cc

+++ b/chrome/renderer/extensions/page_capture_custom_bindings.cc

@@ -29,7 +29,8 @@ void PageCaptureCustomBindings::CreateBlob(

CHECK(args.Length() == 2);

CHECK(args[0]->IsString());

CHECK(args[1]->IsInt32());

- blink::WebString path(base::UTF8ToUTF16(*v8::String::Utf8Value(args[0])));

+ blink::WebString path(

+ blink::WebString::fromUTF8(*v8::String::Utf8Value(args[0])));

blink::WebBlob blob =

blink::WebBlob::createFromFile(path, args[1]->Int32Value());

args.GetReturnValue().Set(