Issue 2651533007: [Video] Remove wrong DCHECK from EnableVideoTrackIfNeeded

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2651533007: [Video] Remove wrong DCHECK from EnableVideoTrackIfNeeded (Closed)

Created:
3 years, 11 months ago by whywhat

Modified:
3 years, 11 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

[Video] Remove wrong DCHECK from EnableVideoTrackIfNeeded The DCHECK doesn't make sense as we might reenable the track during suspend/resume while in the background. BUG=683152 TEST=none Review-Url: https://codereview.chromium.org/2641373002 Cr-Commit-Position: refs/heads/master@{#445128} (cherry picked from commit fd01a87860fe7f105d25135a9ca0f8c3ecd9bdda) Review-Url: https://codereview.chromium.org/2651533007 . Cr-Commit-Position: refs/branch-heads/2987@{#58} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/6f71fe8fcc06145939bcdf31d7ac2e9140fffa3f

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	media/blink/webmediaplayer_impl.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

whywhat

3 years, 11 months ago (2017-01-24 17:55:50 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6f71fe8fcc06145939bcdf31d7ac2e9140fffa3f.