Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2641373002: [Video] Remove wrong DCHECK from EnableVideoTrackIfNeeded (Closed)

Created:
3 years, 11 months ago by whywhat
Modified:
3 years, 11 months ago
CC:
apacible+watch_chromium.org, chromium-reviews, erickung+watch_chromium.org, feature-media-reviews_chromium.org, miu+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Video] Remove wrong DCHECK from EnableVideoTrackIfNeeded The DCHECK doesn't make sense as we might reenable the track during suspend/resume while in the background. BUG=683163 TEST=none Review-Url: https://codereview.chromium.org/2641373002 Cr-Commit-Position: refs/heads/master@{#445128} Committed: https://chromium.googlesource.com/chromium/src/+/fd01a87860fe7f105d25135a9ca0f8c3ecd9bdda

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M media/blink/webmediaplayer_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
whywhat
PTaL, thanks!
3 years, 11 months ago (2017-01-20 18:00:22 UTC) #2
DaleCurtis
lgtm
3 years, 11 months ago (2017-01-20 18:21:18 UTC) #5
sandersd (OOO until July 31)
lgtm
3 years, 11 months ago (2017-01-20 19:01:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641373002/1
3 years, 11 months ago (2017-01-20 19:17:24 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 19:30:59 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fd01a87860fe7f105d25135a9ca0...

Powered by Google App Engine
This is Rietveld 408576698