Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2651533002: [ast] Simplify NewBoilerplateDescription. (Closed)

Created:
3 years, 11 months ago by Franzi
Modified:
3 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ast] Simplify NewBoilerplateDescription. The property backing store size depends on the number of index keys. Pass index keys to the factory function instead calculating the size outside. R=verwaest@chromium.org BUG=v8:5625 Review-Url: https://codereview.chromium.org/2651533002 Cr-Commit-Position: refs/heads/master@{#42637} Committed: https://chromium.googlesource.com/v8/v8/+/82631263c614286b7ebacfb89d09a3619d6e1ade

Patch Set 1 #

Patch Set 2 : Fix DCHECK. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M src/ast/ast.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/factory.cc View 1 2 chunks +7 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (11 generated)
Franzi
PTAL.
3 years, 11 months ago (2017-01-23 14:13:45 UTC) #9
Toon Verwaest
lgtm
3 years, 11 months ago (2017-01-24 17:55:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651533002/20001
3 years, 11 months ago (2017-01-24 18:31:04 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 19:06:09 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/82631263c614286b7ebacfb89d09a3619d6...

Powered by Google App Engine
This is Rietveld 408576698