Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2646333002: [parser] Delete has_seen_proto in ObjectLiteral. (Closed)

Created:
3 years, 11 months ago by Franzi
Modified:
3 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Delete has_seen_proto in ObjectLiteral. For an object literal, has_seen_proto is needed to create the BoilerplateDescription. When iterating over the object properties in the AST, has_seen_proto can easily be computed. The flag in the ObjectLiteral is unnecessary. R=verwaest@chromium.org BUG=v8:5625 Review-Url: https://codereview.chromium.org/2646333002 Cr-Commit-Position: refs/heads/master@{#42601} Committed: https://chromium.googlesource.com/v8/v8/+/679201f67b70c1c52f9d67928faa9b9379a7c888

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -23 lines) Patch
M src/ast/ast.h View 5 chunks +5 lines, -12 lines 0 comments Download
M src/ast/ast.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M src/parsing/parser-base.h View 3 chunks +3 lines, -6 lines 0 comments Download
M src/parsing/preparser.h View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
Franzi
Hi Toon, Another small change. Deleting the has_seen_proto bit that I introduced. Since we iterate ...
3 years, 11 months ago (2017-01-22 22:57:28 UTC) #5
Toon Verwaest
Nice cleanup! lgtm
3 years, 11 months ago (2017-01-23 03:57:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646333002/1
3 years, 11 months ago (2017-01-23 12:17:35 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 12:19:15 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/679201f67b70c1c52f9d67928faa9b9379a...

Powered by Google App Engine
This is Rietveld 408576698