Last_n: Minor follow-up fixes post user interaction triggers.

Last_n: Minor follow-up fixes post user interaction triggers.

This change fixes two issues with the recently landed CL that made
last_n listen to user interaction triggers for snapshot creation:

- Removes the PageQuality alias from the RecentTabHelper header.

So that this alias is not spread to other files importing this header.

- Don't ignore same page navigations for creating new snapshots.

I found out that in same page navigations the contents of the page
can change considerably. So the subcase of segment navigations I was
considering where we would like to avoid extra saves, is only a special
case among all that fit a same page one.

BUG=678367
TBR=dimich@chromium.org

Review-Url: https://codereview.chromium.org/2651433004
Cr-Commit-Position: refs/heads/master@{#445243}
Committed: https://chromium.googlesource.com/chromium/src/+/fe02d6b0fd390b03345187b65e29831f4fb89ac7

[carlosk, 2017-01-21 00:48:11]

The CQ bit was checked by carlosk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-21 00:48:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[carlosk, 2017-01-21 00:49:28]

carlosk@chromium.org changed reviewers:
+ dewittj@chromium.org, dimich@chromium.org

[carlosk, 2017-01-21 00:49:28]

dewittj@, dimich@: PTAL.

[dewittj, 2017-01-21 00:51:52]

lgtm, this makes me wonder if we need a test somewhere

[carlosk, 2017-01-21 00:55:41]

On 2017/01/21 00:51:52, dewittj wrote:
> lgtm, this makes me wonder if we need a test somewhere

So I had previously planned to add a "check that same page navigations are
ignored" test. Do you mean that maybe now we need one to check that they are
*not* ignored?

[carlosk, 2017-01-21 00:56:42]

Description was changed from

==========
Last_n: Minor follow-up fixes post user interaction triggers.

This change fixes two issues with the recently landed CL that made
last_n listen to user interaction triggers for snapshot creation:

- Removes the PageQuality alias from the RecentTabHelper header.

So that this alias is not spread to other files importing this header.

- Don't ignore same page navigations for creating new snapshots.

I found out that in same page navigations the contents of the page
can change considerably. So the subcase of segment navigations I was
considering where we would like to avoid extra saves, is only a special
case among all that fit a same page one.

BUG=678367
==========

to

==========
Last_n: Minor follow-up fixes post user interaction triggers.

This change fixes two issues with the recently landed CL that made
last_n listen to user interaction triggers for snapshot creation:

- Removes the PageQuality alias from the RecentTabHelper header.

So that this alias is not spread to other files importing this header.

- Don't ignore same page navigations for creating new snapshots.

I found out that in same page navigations the contents of the page
can change considerably. So the subcase of segment navigations I was
considering where we would like to avoid extra saves, is only a special
case among all that fit a same page one.

BUG=678367
TBR=dimich@chromium.org
==========

[dewittj, 2017-01-21 01:01:19]

On 2017/01/21 00:55:41, carlosk wrote:
> On 2017/01/21 00:51:52, dewittj wrote:
> > lgtm, this makes me wonder if we need a test somewhere
> 
> So I had previously planned to add a "check that same page navigations are
> ignored" test. Do you mean that maybe now we need one to check that they are
> *not* ignored?

Yeah, that was the idea, since the previous change caused a regression.

[commit-bot: I haz the power, 2017-01-21 01:29:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 01:29:22]

Dry run: This issue passed the CQ dry run.

[carlosk, 2017-01-21 01:30:47]

The CQ bit was checked by carlosk@chromium.org

[commit-bot: I haz the power, 2017-01-21 01:31:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 01:35:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484962247236620, "parent_rev":
"83f3ec1d3e95c1324aa57e3b23e44f4a05a89a06", "commit_rev":
"fe02d6b0fd390b03345187b65e29831f4fb89ac7"}

[commit-bot: I haz the power, 2017-01-21 01:36:12]

Description was changed from

==========
Last_n: Minor follow-up fixes post user interaction triggers.

This change fixes two issues with the recently landed CL that made
last_n listen to user interaction triggers for snapshot creation:

- Removes the PageQuality alias from the RecentTabHelper header.

So that this alias is not spread to other files importing this header.

- Don't ignore same page navigations for creating new snapshots.

I found out that in same page navigations the contents of the page
can change considerably. So the subcase of segment navigations I was
considering where we would like to avoid extra saves, is only a special
case among all that fit a same page one.

BUG=678367
TBR=dimich@chromium.org
==========

to

==========
Last_n: Minor follow-up fixes post user interaction triggers.

This change fixes two issues with the recently landed CL that made
last_n listen to user interaction triggers for snapshot creation:

- Removes the PageQuality alias from the RecentTabHelper header.

So that this alias is not spread to other files importing this header.

- Don't ignore same page navigations for creating new snapshots.

I found out that in same page navigations the contents of the page
can change considerably. So the subcase of segment navigations I was
considering where we would like to avoid extra saves, is only a special
case among all that fit a same page one.

BUG=678367
TBR=dimich@chromium.org

Review-Url: https://codereview.chromium.org/2651433004
Cr-Commit-Position: refs/heads/master@{#445243}
Committed:
https://chromium.googlesource.com/chromium/src/+/fe02d6b0fd390b03345187b65e29...
==========

[commit-bot: I haz the power, 2017-01-21 01:36:13]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fe02d6b0fd390b03345187b65e29...