Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2927)

Unified Diff: chrome/browser/android/offline_pages/recent_tab_helper.h

Issue 2651433004: Last_n: Minor follow-up fixes post user interaction triggers. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/recent_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/recent_tab_helper.h
diff --git a/chrome/browser/android/offline_pages/recent_tab_helper.h b/chrome/browser/android/offline_pages/recent_tab_helper.h
index f77b02fe4b75127c4d33efdaa353fe4875fbeb19..6aa442ec8151aef2fcab62a284ac2dbe0f60736c 100644
--- a/chrome/browser/android/offline_pages/recent_tab_helper.h
+++ b/chrome/browser/android/offline_pages/recent_tab_helper.h
@@ -22,8 +22,6 @@ class NavigationHandle;
namespace offline_pages {
-using PageQuality = SnapshotController::PageQuality;
-
// Attaches to every WebContent shown in a tab. Waits until the WebContent is
// loaded to proper degree and then makes a snapshot of the page. Removes the
// oldest snapshot in the 'ring buffer'. As a result, there is always up to N
@@ -100,7 +98,8 @@ class RecentTabHelper
// Expected snapshot quality should the saving succeed. This value is only
// valid if |page_snapshot_completed| is true.
- PageQuality expected_page_quality = PageQuality::POOR;
+ SnapshotController::PageQuality expected_page_quality =
+ SnapshotController::PageQuality::POOR;
};
explicit RecentTabHelper(content::WebContents* web_contents);
@@ -156,7 +155,8 @@ class RecentTabHelper
// Track the page quality status of the last saved snapshot for the current
// page. It is generally reset upon new navigations.
- PageQuality last_n_latest_saved_quality_ = PageQuality::POOR;
+ SnapshotController::PageQuality last_n_latest_saved_quality_ =
+ SnapshotController::PageQuality::POOR;
base::WeakPtrFactory<RecentTabHelper> weak_ptr_factory_;
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/recent_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698