Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2651303003: Reland of move remnants of DHE support. (Closed)

Created:
3 years, 11 months ago by kjellander_chromium
Modified:
3 years, 11 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, asvitkine+watch_chromium.org, mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of move remnants of DHE support. (patchset #1 id:1 of https://codereview.chromium.org/2656953002/ ) Reason for revert: Did not solve the failing test: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/62881 Original issue's description: > Revert of Remove remnants of DHE support. (patchset #3 id:40001 of https://codereview.chromium.org/2653773003/ ) > > Reason for revert: > I suspect this breaks https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/62851 since the trybot that ran (and passed) was a Win x64 config (win_chromium_x64_rel_ng). > The x64 windows bot doesn't break post-commit. > This was the only CL in the blame list touching encryption IIUC. > > Original issue's description: > > Remove remnants of DHE support. > > > > The admin policy has now expired, so we can unwind all code relating to > > it. > > > > The deprecated cipher fallback will be removed in a follow-up, tracked > > by https://crbug.com/684730. > > > > BUG=619194 > > > > Review-Url: https://codereview.chromium.org/2653773003 > > Cr-Commit-Position: refs/heads/master@{#446049} > > Committed: https://chromium.googlesource.com/chromium/src/+/6b4943bfc61acc877f92b183b849922edbe85e8d > > TBR=svaldez@chromium.org,pastarmovj@chromium.org,davidben@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=619194 > > Review-Url: https://codereview.chromium.org/2656953002 > Cr-Commit-Position: refs/heads/master@{#446249} > Committed: https://chromium.googlesource.com/chromium/src/+/8533a15e602b656ccac9d4779c7ca479c32ed954 TBR=svaldez@chromium.org,pastarmovj@chromium.org,davidben@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=619194 Review-Url: https://codereview.chromium.org/2651303003 Cr-Commit-Position: refs/heads/master@{#446269} Committed: https://chromium.googlesource.com/chromium/src/+/1ae83a08f3b0b6831e5dbdaae12635010367b246

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -105 lines) Patch
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 2 chunks +4 lines, -7 lines 0 comments Download
M components/policy/resources/policy_templates.json View 3 chunks +3 lines, -0 lines 0 comments Download
M components/ssl_config/ssl_config_prefs.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/ssl_config/ssl_config_prefs.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/ssl_config/ssl_config_service_manager_pref.cc View 4 chunks +0 lines, -6 lines 0 comments Download
M net/socket/ssl_client_socket_impl.cc View 2 chunks +2 lines, -24 lines 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 2 chunks +2 lines, -34 lines 0 comments Download
M net/ssl/ssl_config.h View 1 chunk +3 lines, -3 lines 0 comments Download
M net/ssl/ssl_config.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/url_request/url_request_unittest.cc View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kjellander_chromium
Created Reland of move remnants of DHE support.
3 years, 11 months ago (2017-01-26 07:34:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651303003/1
3 years, 11 months ago (2017-01-26 07:34:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1ae83a08f3b0b6831e5dbdaae12635010367b246
3 years, 11 months ago (2017-01-26 07:35:53 UTC) #6
pastarmovj
3 years, 11 months ago (2017-01-26 20:17:40 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698