Remove remnants of DHE support.

Remove remnants of DHE support.

The admin policy has now expired, so we can unwind all code relating to
it.

The deprecated cipher fallback will be removed in a follow-up, tracked
by https://crbug.com/684730.

BUG=619194
Review-Url: https://codereview.chromium.org/2653773003
Cr-Commit-Position: refs/heads/master@{#446049}
Committed: https://chromium.googlesource.com/chromium/src/+/6b4943bfc61acc877f92b183b849922edbe85e8d

[davidben, 2017-01-23 22:33:04]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[davidben, 2017-01-23 22:34:35]

davidben@chromium.org changed reviewers:
+ pastarmovj@chromium.org, svaldez@chromium.org

[davidben, 2017-01-23 22:34:35]

pastarmovj: For chrome/browser/policy/
svaldez: Overall review.

[commit-bot: I haz the power, 2017-01-23 22:34:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 23:19:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 23:19:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pastarmovj, 2017-01-23 23:28:07]

Please also mark the policy as deprecated here :
https://cs.chromium.org/chromium/src/components/policy/resources/policy_templ...
(add "deprecated": True like here
https://cs.chromium.org/chromium/src/components/policy/resources/policy_templ...
)

https://codereview.chromium.org/2653773003/diff/1/chrome/test/data/policy/pol...
File chrome/test/data/policy/policy_test_cases.json (left):

https://codereview.chromium.org/2653773003/diff/1/chrome/test/data/policy/pol...
chrome/test/data/policy/policy_test_cases.json:1964: "os": ["win", "linux",
"mac", "chromeos"],
Please use a "note" field to mark this policy as deprecated. See line 384 for an
example.

[davidben, 2017-01-24 20:54:32]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 20:54:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[davidben, 2017-01-24 20:55:12]

Description was changed from

==========
Remove remnants of DHE support.

The admin policy has now expired, so we can unwind all code relating to
it. This includes removing the deprecated cipher fallback, now that no
cipher suites are left under it.

BUG=675828,619194
==========

to

==========
Remove remnants of DHE support.

The admin policy has now expired, so we can unwind all code relating to
it.

The deprecated cipher fallback will be removed in a follow-up, tracked
by https://crbug.com/684730.

BUG=619194
==========

[davidben, 2017-01-24 20:59:12]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 20:59:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[davidben, 2017-01-24 21:00:03]

svaldez: Could you take another pass. I split the fallback stuff out; will
remove it in a follow-up due to the test failure.

> Please also mark the policy as deprecated

Done. Also did it for the older policies I'd deprecated.

https://codereview.chromium.org/2653773003/diff/1/chrome/test/data/policy/pol...
File chrome/test/data/policy/policy_test_cases.json (left):

https://codereview.chromium.org/2653773003/diff/1/chrome/test/data/policy/pol...
chrome/test/data/policy/policy_test_cases.json:1964: "os": ["win", "linux",
"mac", "chromeos"],
On 2017/01/23 23:28:06, pastarmovj wrote:
> Please use a "note" field to mark this policy as deprecated. See line 384 for
an
> example.

Done. Also added it for the others I'd previously emptied.

[svaldez, 2017-01-24 21:06:00]

lgtm.

[pastarmovj, 2017-01-24 21:06:28]

On 2017/01/24 21:00:03, davidben wrote:
> svaldez: Could you take another pass. I split the fallback stuff out; will
> remove it in a follow-up due to the test failure.
> 
> > Please also mark the policy as deprecated
> 
> Done. Also did it for the older policies I'd deprecated.
> 
>
https://codereview.chromium.org/2653773003/diff/1/chrome/test/data/policy/pol...
> File chrome/test/data/policy/policy_test_cases.json (left):
> 
>
https://codereview.chromium.org/2653773003/diff/1/chrome/test/data/policy/pol...
> chrome/test/data/policy/policy_test_cases.json:1964: "os": ["win", "linux",
> "mac", "chromeos"],
> On 2017/01/23 23:28:06, pastarmovj wrote:
> > Please use a "note" field to mark this policy as deprecated. See line 384
for
> an
> > example.
> 
> Done. Also added it for the others I'd previously emptied.

lgtm. Thanks for the extra cleanups! :)

[davidben, 2017-01-24 21:08:23]

The CQ bit was unchecked by davidben@chromium.org

[davidben, 2017-01-24 21:08:26]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2017-01-24 21:08:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 21:39:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 21:39:39]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[davidben, 2017-01-24 21:56:35]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2017-01-24 21:56:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 22:03:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 22:03:45]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[davidben, 2017-01-24 22:06:15]

Looks like both infra and the Android build are borked. I'm going to try this
again tomorrow.

[davidben, 2017-01-25 16:46:44]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2017-01-25 16:46:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 17:34:02]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485362804202190,
"parent_rev": "98748b23148f0885554558339401ab3b637ecebe", "commit_rev":
"6b4943bfc61acc877f92b183b849922edbe85e8d"}

[commit-bot: I haz the power, 2017-01-25 17:34:42]

Description was changed from

==========
Remove remnants of DHE support.

The admin policy has now expired, so we can unwind all code relating to
it.

The deprecated cipher fallback will be removed in a follow-up, tracked
by https://crbug.com/684730.

BUG=619194
==========

to

==========
Remove remnants of DHE support.

The admin policy has now expired, so we can unwind all code relating to
it.

The deprecated cipher fallback will be removed in a follow-up, tracked
by https://crbug.com/684730.

BUG=619194

Review-Url: https://codereview.chromium.org/2653773003
Cr-Commit-Position: refs/heads/master@{#446049}
Committed:
https://chromium.googlesource.com/chromium/src/+/6b4943bfc61acc877f92b183b849...
==========

[commit-bot: I haz the power, 2017-01-25 17:34:43]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6b4943bfc61acc877f92b183b849...

[kjellander_chromium, 2017-01-26 06:17:01]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2656953002/ by kjellander@chromium.org.

The reason for reverting is: I suspect this breaks
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/bui...
since the trybot that ran (and passed) was a Win x64 config
(win_chromium_x64_rel_ng). 
The x64 windows bot doesn't break post-commit. 
This was the only CL in the blame list touching encryption IIUC..